Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 1539133002: Oilpan: avoid heap allocation in MajorGCWrapperVisitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add explanatory comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index 801aa58343f679f17581680a5161ca964526af4b..4e879e07f0ea499a7e649c85dc024f079f77c6f9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -234,7 +234,10 @@ private:
}
v8::Isolate* m_isolate;
- WillBePersistentHeapVector<RawPtrWillBeMember<Node>> m_groupsWhichNeedRetainerInfo;
+ // v8 guarantees that Blink will not regain control while a v8 GC runs
+ // (=> no Oilpan GCs will be triggered), hence raw, untraced members
+ // can safely be kept here.
+ Vector<RawPtrWillBeUntracedMember<Node>> m_groupsWhichNeedRetainerInfo;
int m_domObjectsWithPendingActivity;
bool m_liveRootGroupIdSet;
bool m_constructRetainedObjectInfos;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698