Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 153913010: Revert of Perform a microtask checkpoint for document.write('<script><\/script>') (Closed)

Created:
6 years, 10 months ago by tkent
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, tonyg, abarth-chromium
Visibility:
Public.

Description

Revert of Perform a microtask checkpoint for document.write('<script><\/script>') (https://codereview.chromium.org/130983011/) Reason for revert: Broke MutationObserver consistency. Original issue's description: > Perform a microtask checkpoint for document.write('<script><\/script>') > > http://whatwg.org/html#scriptEndTag > > The spec does 'Perform a microtask checkpoint' unconditionally for 'An > end tag whose tag name is "script"', which means that document.write > can trigger it while a script is running. > > A spec bug was filed for the similar situation with 'Provide a stable > state' on the assumption that this was a mistake, but it was not: > https://www.w3.org/Bugs/Public/show_bug.cgi?id=24361 > > Unless performing a microtask checkpoint here will lead to other > complications, it's simpler to just align with the spec. > > BUG=340322 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166445 TBR=eseidel@chromium.org,esprehn@chromium.org,adamk@chromium.org,rafaelw@chromium.org,philipj@opera.com NOTREECHECKS=true NOTRY=true BUG=340322 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
D LayoutTests/fast/dom/MutationObserver/script-end-tag.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/dom/MutationObserver/script-end-tag-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Perform a microtask checkpoint for document.write('<script><\/script>')
6 years, 10 months ago (2014-02-12 03:50:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/153913010/1
6 years, 10 months ago (2014-02-12 03:52:41 UTC) #2
commit-bot: I haz the power
Change committed as 166960
6 years, 10 months ago (2014-02-12 03:54:28 UTC) #3
tkent
6 years, 10 months ago (2014-02-12 03:59:05 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/160293002/ by tkent@chromium.org.

The reason for reverting is: Wrong revert

.

Powered by Google App Engine
This is Rietveld 408576698