Issue 153913004: gesture-nav: Use a WebContentsObserver to more reliably dismiss the navigation overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153913004: gesture-nav: Use a WebContentsObserver to more reliably dismiss the navigation overlay. (Closed)

Created:
6 years, 10 months ago by sadrul

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gesture-nav: Use a WebContentsObserver to more reliably dismiss the navigation overlay. WebContentsObserver provides the necessary notifications to know when to remove the screenshot overlay during gesture-navigation. So use those instead of PaintObserver. BUG=340751 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249073

Patch Set 1 #

Patch Set 2 : . #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -95 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura.h	View	1	3 chunks	+0 lines, -32 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1	8 chunks	+0 lines, -15 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.cc	View	1	8 chunks	+13 lines, -48 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 10 months ago (2014-02-05 19:24:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r249073 (presubmit successful).

Expand Messages | Collapse Messages