Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 153913004: gesture-nav: Use a WebContentsObserver to more reliably dismiss the navigation overlay. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 21c983a3f5330bd03098f6fa06503f5c26b4082a..80c4e0468d7447ffb69566a5a9cbb90c43cbc683 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -486,7 +486,6 @@ RenderWidgetHostViewAura::RenderWidgetHostViewAura(RenderWidgetHost* host)
accelerated_compositing_state_changed_(false),
can_lock_compositor_(YES),
cursor_visibility_state_in_renderer_(UNKNOWN),
- paint_observer_(NULL),
touch_editing_client_(NULL),
delegated_frame_evictor_(new DelegatedFrameEvictor(this)),
weak_ptr_factory_(this) {
@@ -917,8 +916,6 @@ void RenderWidgetHostViewAura::UpdateCursor(const WebCursor& cursor) {
}
void RenderWidgetHostViewAura::SetIsLoading(bool is_loading) {
- if (is_loading_ && !is_loading && paint_observer_)
- paint_observer_->OnPageLoadComplete();
is_loading_ = is_loading;
UpdateCursorIfOverSelf();
}
@@ -1497,8 +1494,6 @@ void RenderWidgetHostViewAura::SwapDelegatedFrame(
current_frame_size_ = frame_size_in_dip;
CheckResizeLock();
- if (paint_observer_)
- paint_observer_->OnUpdateCompositorContent();
window_->SchedulePaintInRect(damage_rect_in_dip);
pending_delegated_ack_count_++;
@@ -1613,8 +1608,6 @@ void RenderWidgetHostViewAura::SwapSoftwareFrame(
AsWeakPtr(),
output_surface_id));
}
- if (paint_observer_)
- paint_observer_->OnUpdateCompositorContent();
DidReceiveFrameFromRenderer();
software_frame_manager_->SwapToNewFrameComplete(!host_->is_hidden());
@@ -1783,8 +1776,6 @@ void RenderWidgetHostViewAura::BuffersSwapped(
rect_to_paint.Inset(-1, -1);
rect_to_paint.Intersect(window_->bounds());
- if (paint_observer_)
- paint_observer_->OnUpdateCompositorContent();
window_->SchedulePaintInRect(rect_to_paint);
for (size_t i = 0; i < latency_info.size(); i++)
compositor->SetLatencyInfo(latency_info[i]);
@@ -2613,8 +2604,6 @@ void RenderWidgetHostViewAura::OnPaint(gfx::Canvas* canvas) {
paint_canvas_ = NULL;
backing_store->SkiaShowRect(gfx::Point(), canvas);
- if (paint_observer_)
- paint_observer_->OnPaintComplete();
ui::Compositor* compositor = GetCompositor();
if (compositor) {
for (size_t i = 0; i < software_latency_info_.size(); i++)
@@ -3204,8 +3193,6 @@ void RenderWidgetHostViewAura::OnCompositingStarted(
void RenderWidgetHostViewAura::OnCompositingEnded(
ui::Compositor* compositor) {
- if (paint_observer_)
- paint_observer_->OnCompositingComplete();
}
void RenderWidgetHostViewAura::OnCompositingAborted(
@@ -3311,8 +3298,6 @@ void RenderWidgetHostViewAura::OnLostResources() {
// RenderWidgetHostViewAura, private:
RenderWidgetHostViewAura::~RenderWidgetHostViewAura() {
- if (paint_observer_)
- paint_observer_->OnViewDestroyed();
if (touch_editing_client_)
touch_editing_client_->OnViewDestroyed();
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.h ('k') | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698