Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1539043002: Pull SecurityStateModel out into a component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit test debugging Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index 3efdb082cc855c2ebadfa8961161b7729ba55d73..fa8191b6866624d9faf05476942cf2da1019b84f 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -32,7 +32,6 @@
#include "chrome/browser/ssl/chrome_security_state_model_client.h"
#include "chrome/browser/ssl/chrome_ssl_host_state_delegate.h"
#include "chrome/browser/ssl/common_name_mismatch_handler.h"
-#include "chrome/browser/ssl/security_state_model.h"
#include "chrome/browser/ssl/ssl_blocking_page.h"
#include "chrome/browser/ssl/ssl_error_handler.h"
#include "chrome/browser/ui/browser.h"
@@ -49,6 +48,8 @@
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/security_interstitials/core/controller_client.h"
#include "components/security_interstitials/core/metrics_helper.h"
+#include "components/security_state/security_state_model.h"
+#include "components/security_state/switches.h"
#include "components/ssl_errors/error_classification.h"
#include "components/variations/variations_associated_data.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
@@ -1117,7 +1118,8 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestWSSInvalidCertAndGoForward) {
IN_PROC_BROWSER_TEST_F(SSLUITest, TestMarkNonSecureAs) {
scoped_refptr<base::FieldTrial> trial =
base::FieldTrialList::CreateFieldTrial(
- "MarkNonSecureAs", switches::kMarkNonSecureAsNonSecure);
+ "MarkNonSecureAs",
+ security_state::switches::kMarkNonSecureAsNonSecure);
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -1128,21 +1130,21 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestMarkNonSecureAs) {
ASSERT_TRUE(model_client);
ui_test_utils::NavigateToURL(browser(), GURL("file:/"));
- EXPECT_EQ(SecurityStateModel::NONE,
+ EXPECT_EQ(security_state::SecurityStateModel::NONE,
model_client->GetSecurityInfo().security_level);
ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
- EXPECT_EQ(SecurityStateModel::NONE,
+ EXPECT_EQ(security_state::SecurityStateModel::NONE,
model_client->GetSecurityInfo().security_level);
ui_test_utils::NavigateToURL(browser(), GURL("data:text/plain,hello"));
- EXPECT_EQ(SecurityStateModel::NONE,
+ EXPECT_EQ(security_state::SecurityStateModel::NONE,
model_client->GetSecurityInfo().security_level);
ui_test_utils::NavigateToURL(
browser(),
GURL("blob:chrome%3A//newtab/49a463bb-fac8-476c-97bf-5d7076c3ea1a"));
- EXPECT_EQ(SecurityStateModel::NONE,
+ EXPECT_EQ(security_state::SecurityStateModel::NONE,
model_client->GetSecurityInfo().security_level);
}

Powered by Google App Engine
This is Rietveld 408576698