Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/ssl/security_state_model_android.h

Issue 1539043002: Pull SecurityStateModel out into a component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit test debugging Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/security_state_model_android.h
diff --git a/chrome/browser/ssl/security_state_model_android.h b/chrome/browser/ssl/security_state_model_android.h
index 1a7f526a0912177fe13bc1c8f5fac7458af56bec..299866c351b6c41f89e29201f615db2a15ed693a 100644
--- a/chrome/browser/ssl/security_state_model_android.h
+++ b/chrome/browser/ssl/security_state_model_android.h
@@ -7,6 +7,36 @@
#include "base/android/jni_android.h"
+// TODO(estark): This is a temporary duplicated enum that is only used
blundell 2016/01/05 16:02:16 Hmm, this seems unfortunate. What's the blocker on
estark 2016/01/05 22:59:30 No blocker, I was just trying to keep the CL to a
+// by Java code. It should go away and the Java code should use the
+// componentized security_state::SecurityStateModel::SecurityLevel enum
+// instead. https://crbug.com/515071
+//
+// A Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.ssl
+// GENERATED_JAVA_CLASS_NAME_OVERRIDE: ConnectionSecurityLevel
+enum SecurityLevel {
+ // HTTP/no URL/HTTPS but with insecure passive content on the page
+ NONE,
+
+ // HTTPS with valid EV cert
+ EV_SECURE,
+
+ // HTTPS (non-EV) with valid cert
+ SECURE,
+
+ // HTTPS, but with an outdated protocol version
+ SECURITY_WARNING,
+
+ // HTTPS, but the certificate verification chain is anchored on a
+ // certificate that was installed by the system administrator
+ SECURITY_POLICY_WARNING,
+
+ // Attempted HTTPS and failed, page not authenticated, or HTTPS with
+ // insecure active content on the page
+ SECURITY_ERROR,
+};
+
bool RegisterSecurityStateModelAndroid(JNIEnv* env);
#endif // CHROME_BROWSER_SSL_SECURITY_STATE_MODEL_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698