Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: build/common.gypi

Issue 1538973002: Reland Don't set -fvisibility=hidden for iOS Debug in GYP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: combine conditions sections Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5056 matching lines...) Expand 10 before | Expand all | Expand 10 after
5067 'CLANG_LINK_OBJC_RUNTIME': 'NO', # -fno-objc-link-runtime 5067 'CLANG_LINK_OBJC_RUNTIME': 'NO', # -fno-objc-link-runtime
5068 'COPY_PHASE_STRIP': 'NO', 5068 'COPY_PHASE_STRIP': 'NO',
5069 'GCC_C_LANGUAGE_STANDARD': 'c99', # -std=c99 5069 'GCC_C_LANGUAGE_STANDARD': 'c99', # -std=c99
5070 'GCC_CW_ASM_SYNTAX': 'NO', # No -fasm-blocks 5070 'GCC_CW_ASM_SYNTAX': 'NO', # No -fasm-blocks
5071 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions 5071 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions
5072 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti 5072 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti
5073 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings 5073 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings
5074 # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden 5074 # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden
5075 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', 5075 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
5076 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors 5076 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
5077 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5078 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics 5077 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
5079 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 5078 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
5080 'GCC_VERSION': '4.2', 5079 'GCC_VERSION': '4.2',
5081 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof 5080 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
5082 'USE_HEADERMAP': 'NO', 5081 'USE_HEADERMAP': 'NO',
5083 'WARNING_CFLAGS': [ 5082 'WARNING_CFLAGS': [
5084 '-Wall', 5083 '-Wall',
5085 '-Wextra', 5084 '-Wextra',
5086 # Don't warn about unused function parameters. 5085 # Don't warn about unused function parameters.
5087 '-Wno-unused-parameter', 5086 '-Wno-unused-parameter',
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
5139 ['OS=="ios" and target_subarch!="arm32" and \ 5138 ['OS=="ios" and target_subarch!="arm32" and \
5140 "<(GENERATOR)"=="xcode"', { 5139 "<(GENERATOR)"=="xcode"', {
5141 'OTHER_CFLAGS': [ 5140 'OTHER_CFLAGS': [
5142 # TODO(ios): when building Chrome for iOS on 64-bit platform 5141 # TODO(ios): when building Chrome for iOS on 64-bit platform
5143 # with Xcode, the -Wshorted-64-to-32 warning is automatically 5142 # with Xcode, the -Wshorted-64-to-32 warning is automatically
5144 # enabled. This cause failures when compiling protobuf code, 5143 # enabled. This cause failures when compiling protobuf code,
5145 # so disable the warning. http://crbug.com/359107 5144 # so disable the warning. http://crbug.com/359107
5146 '-Wno-shorten-64-to-32', 5145 '-Wno-shorten-64-to-32',
5147 ], 5146 ],
5148 }], 5147 }],
5149 ], 5148 ],
sdefresne 2016/01/07 16:50:21 I think you should put your code here.
5150 }, 5149 },
5151 'conditions': [ 5150 'conditions': [
5152 ['clang==1', { 5151 ['clang==1', {
5153 'variables': { 5152 'variables': {
5154 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin', 5153 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin',
5155 }, 5154 },
5156 }], 5155 }],
5157 ['asan==1', { 5156 ['asan==1', {
5158 'xcode_settings': { 5157 'xcode_settings': {
5159 'OTHER_CFLAGS': [ 5158 'OTHER_CFLAGS': [
(...skipping 20 matching lines...) Expand all
5180 ['_toolset=="target"', { 5179 ['_toolset=="target"', {
5181 'cflags': [ 5180 'cflags': [
5182 '-fsanitize-coverage=<(sanitizer_coverage)', 5181 '-fsanitize-coverage=<(sanitizer_coverage)',
5183 ], 5182 ],
5184 'defines': [ 5183 'defines': [
5185 'SANITIZER_COVERAGE', 5184 'SANITIZER_COVERAGE',
5186 ], 5185 ],
5187 }], 5186 }],
5188 ], 5187 ],
5189 }], 5188 }],
5189 ['OS=="mac"', {
5190 'xcode_settings': {
5191 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5192 },
5193 }],
5194 ['OS=="ios"', {
5195 'configurations': {
5196 'Debug': {
5197 'xcode_settings': {
5198 # XCTests inject a dynamic library into the application. If
5199 # fvisibility is set to hidden, then some symbols needed by
5200 # XCTests are not available. Disable this setting for
5201 # Debug configuration.
5202 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
5203 },
5204 },
5205 'Release': {
5206 'xcode_settings': {
5207 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5208 },
5209 },
5210 },
5211 }],
5190 ], 5212 ],
5191 'target_conditions': [ 5213 'target_conditions': [
5192 ['_type!="static_library"', { 5214 ['_type!="static_library"', {
5193 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, 5215 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']},
5194 'conditions': [ 5216 'conditions': [
5195 ['asan==1', { 5217 ['asan==1', {
5196 'xcode_settings': { 5218 'xcode_settings': {
5197 'OTHER_LDFLAGS': [ 5219 'OTHER_LDFLAGS': [
5198 '-fsanitize=address', 5220 '-fsanitize=address',
5199 ], 5221 ],
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
6395 # settings in target dicts. SYMROOT is a special case, because many other 6417 # settings in target dicts. SYMROOT is a special case, because many other
6396 # Xcode variables depend on it, including variables such as 6418 # Xcode variables depend on it, including variables such as
6397 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6419 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6398 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6420 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6399 # files to appear (when present) in the UI as actual files and not red 6421 # files to appear (when present) in the UI as actual files and not red
6400 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6422 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6401 # and therefore SYMROOT, needs to be set at the project level. 6423 # and therefore SYMROOT, needs to be set at the project level.
6402 'SYMROOT': '<(DEPTH)/xcodebuild', 6424 'SYMROOT': '<(DEPTH)/xcodebuild',
6403 }, 6425 },
6404 } 6426 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698