Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/a64/macro-assembler-a64.cc

Issue 153893009: A64: Set function type correctly in CallFunctionStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/a64/code-stubs-a64.cc ('K') | « src/a64/code-stubs-a64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/macro-assembler-a64.cc
diff --git a/src/a64/macro-assembler-a64.cc b/src/a64/macro-assembler-a64.cc
index 71be858279fd2e7a627f77553ba0f5d87a0a7055..c55a59fbb8d708ce3f3f7dfa70da5e9589e7c28a 100644
--- a/src/a64/macro-assembler-a64.cc
+++ b/src/a64/macro-assembler-a64.cc
@@ -1338,9 +1338,7 @@ void MacroAssembler::CallApiFunctionAndReturn(
ExternalReference::handle_scope_level_address(isolate()),
next_address);
- ASSERT(!AreAliased(function_address, x1, x2));
- // TODO(all): Why do we care about aliasing x2? (This function uses x1 as a
- // scratch regiser.)
+ ASSERT(function_address.is(x1) || function_address.is(x2));
ulan 2014/02/10 19:28:41 This is from https://codereview.chromium.org/15900
Label profiler_disabled;
Label end_profiler_check;
« src/a64/code-stubs-a64.cc ('K') | « src/a64/code-stubs-a64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698