Chromium Code Reviews Chromium Code Reviews
Issue 15389003:
Loosen a bit the HTML hierarchy required for Tabs to work, Improved UX of the dev tools (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/apps_debugger/main.html |
| diff --git a/chrome/browser/resources/apps_debugger/main.html b/chrome/browser/resources/apps_debugger/main.html |
| index e4d79fc414ff668721bf61f311a492cd20adb733..47e1e7431817e996d73e0d11c9122545c5677f6f 100644 |
| --- a/chrome/browser/resources/apps_debugger/main.html |
| +++ b/chrome/browser/resources/apps_debugger/main.html |
| @@ -8,14 +8,14 @@ found in the LICENSE file. |
| --> |
| <head> |
| <meta charset="utf-8"> |
| - <link rel="stylesheet" href="css/items.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/chrome_shared.css"> |
| - <link rel="stylesheet" href="css/pack_item_overlay.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/alert_overlay.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/tabs.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/overlay.css"> |
| <link rel="stylesheet" href="../../../../ui/webui/resources/css/trash.css"> |
| <link rel="stylesheet" href="../uber/uber_shared.css"> |
| + <link rel="stylesheet" href="css/pack_item_overlay.css"> |
| + <link rel="stylesheet" href="css/items.css"> |
| <script src="js/main_scripts.js"></script> |
| </head> |
| @@ -25,23 +25,30 @@ found in the LICENSE file. |
| <include src="../../../../ui/webui/resources/html/alert_overlay.html"> |
| </div> |
| <div class="page" id="extension-settings"> |
| - <h1 i18n-content="appsDevtoolTitle"></h1> |
| <tabbox id="tab-box"> |
| - <tabs id="tabs"> |
| - <tab i18n-content="appsDevtoolApps"></tab> |
| - <tab i18n-content="appsDevtoolExtensions"></tab> |
| - </tabs> |
| - <div id="developer-controls"> |
| - <button id="load-unpacked" |
| - i18n-content="appsDevtoolLoadUnpackedButton"></button> |
| - <button id="pack-item" |
| - i18n-content="appsDevtoolPackButton"></button> |
| - <button id= "update-items-now" |
| - i18n-content="appsDevtoolUpdateButton"></button> |
| - <input id="search" type="text" |
| - i18n-values=".placeholder:appsDevtoolSearch" spellcheck="false"> |
| - <hr> |
| - </div> |
| + <div id="header"> |
| + <div id="developer-controls"> |
| + <button id="load-unpacked" |
| + i18n-content="appsDevtoolLoadUnpackedButton"></button> |
|
Dan Beam
2013/05/23 23:06:48
4 \s indent or lining up attributes -- be consiste
dvh
2013/05/24 04:33:42
Done.
|
| + <button id="pack-item" i18n-content="appsDevtoolPackButton"> |
| + </button> |
| + <button id="update-items-now" |
| + i18n-content="appsDevtoolUpdateButton"> |
| + </button> |
| + <h1 id="header-title" i18n-content="appsDevtoolTitle"></h1> |
| + <input id="search" type="text" |
| + i18n-values=".placeholder:appsDevtoolSearch" spellcheck="false" |
| + placeholder="Search"> |
|
Dan Beam
2013/05/23 23:06:48
l10n?
dvh
2013/05/24 04:33:42
I removed placeholder="Search". I think that's a g
|
| + </div> |
| + <div id="tabs-header-container"> |
| + <tabs id="tabs" tabindex="0"> |
| + <tab i18n-content="appsDevtoolApps"></tab> |
| + <tab i18n-content="appsDevtoolExtensions"></tab> |
| + </tabs> |
| + </div> |
| + <div id="header-bottom-gradient"> |
|
Dan Beam
2013/05/23 23:06:48
nit: <div id="header-bottom-gradient"></div>
dvh
2013/05/24 04:33:42
Done.
|
| + </div> |
| + </div> <!-- #header --> |
|
Dan Beam
2013/05/23 23:06:48
^ we don't really have a precedent for <!-- doing
dvh
2013/05/24 04:33:42
I'll remove that anyway.
|
| <tabpanels id="tab-panels"> |
| <!-- Apps Tab --> |
| <tabpanel id="apps-tab"> |
