chrome/browser/resources/apps_debugger/main.html - Issue 15389003: Loosen a bit the HTML hierarchy required for Tabs to work, Improved UX of the dev tools

Side by Side Diff: chrome/browser/resources/apps_debugger/main.html

Issue 15389003: Loosen a bit the HTML hierarchy required for Tabs to work, Improved UX of the dev tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed call to console.trace() Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/apps_debugger/css/items.css ('K') | « chrome/browser/resources/apps_debugger/css/items.css ('k') | ui/webui/resources/js/cr/ui/tabs.js » ('j') | ui/webui/resources/js/cr/ui/tabs.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>
	dvh 2013/05/24 04:33:42 I tried it to change to the following: <html i18n- I tried it to change to the following: <html i18n-values="dir:textdirection;" class="loading"> in order to support RTL but it failed with an exception. "Uncaught TypeError: Cannot call method 'getValue' of undefined", source: chrome-extension://lphgohfeebnhcpiohjndkgbhhkoapkjc/js/main_scripts.js (1363) It failed on the following code (see last line). Is there anything obvious that I missed? << 'i18n-values': function(element, attributeAndKeys, dictionary) { var parts = attributeAndKeys.replace(/\s/g, '').split(/;/); parts.forEach(function(part) { if (!part) return; var attributeAndKeyPair = part.match(/^([^:]+):(.+)$/); if (!attributeAndKeyPair) throw new Error('malformed i18n-values: ' + attributeAndKeys); var propName = attributeAndKeyPair[1]; var propExpr = attributeAndKeyPair[2]; var value = dictionary.getValue(propExpr); // <- here Show quoted text >> Dan Beam 2013/05/24 04:40:20 you probably need to include load_time_data.js and Show quoted text On 2013/05/24 04:33:42, dvh wrote: > I tried it to change to the following: > <html i18n-values="dir:textdirection;" class="loading"> > in order to support RTL but it failed with an exception. > > "Uncaught TypeError: Cannot call method 'getValue' of undefined", source: > chrome-extension://lphgohfeebnhcpiohjndkgbhhkoapkjc/js/main_scripts.js (1363) > > It failed on the following code (see last line). > Is there anything obvious that I missed? > > << > 'i18n-values': function(element, attributeAndKeys, dictionary) { > var parts = attributeAndKeys.replace(/\s/g, '').split(/;/); > parts.forEach(function(part) { > if (!part) > return; > > var attributeAndKeyPair = part.match(/^([^:]+):(.+)$/); > if (!attributeAndKeyPair) > throw new Error('malformed i18n-values: ' + attributeAndKeys); > > var propName = attributeAndKeyPair[1]; > var propExpr = attributeAndKeyPair[2]; > > var value = dictionary.getValue(propExpr); // <- here > >> you probably need to include load_time_data.js and/or run this https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/web_ui_ut... on your i18n dictionary (that you pass from C++ to JS)
3 <!--	3 <!--

4	4

5 Copyright (c) 2012 The Chromium Authors. All rights reserved.	5 Copyright (c) 2012 The Chromium Authors. All rights reserved.

6 Use of this source code is governed by a BSD-style license that can be	6 Use of this source code is governed by a BSD-style license that can be

7 found in the LICENSE file.	7 found in the LICENSE file.

8 -->	8 -->

9 <head>	9 <head>

10 <meta charset="utf-8">	10 <meta charset="utf-8">

11 <link rel="stylesheet" href="css/items.css">

12 <link rel="stylesheet" href="../../../../ui/webui/resources/css/chrome_share d.css">	11 <link rel="stylesheet" href="../../../../ui/webui/resources/css/chrome_share d.css">

13 <link rel="stylesheet" href="css/pack_item_overlay.css">

14 <link rel="stylesheet" href="../../../../ui/webui/resources/css/alert_overla y.css">	12 <link rel="stylesheet" href="../../../../ui/webui/resources/css/alert_overla y.css">

15 <link rel="stylesheet" href="../../../../ui/webui/resources/css/tabs.css">	13 <link rel="stylesheet" href="../../../../ui/webui/resources/css/tabs.css">

16 <link rel="stylesheet" href="../../../../ui/webui/resources/css/overlay.css" >	14 <link rel="stylesheet" href="../../../../ui/webui/resources/css/overlay.css" >

17 <link rel="stylesheet" href="../../../../ui/webui/resources/css/trash.css">	15 <link rel="stylesheet" href="../../../../ui/webui/resources/css/trash.css">

18 <link rel="stylesheet" href="../uber/uber_shared.css">	16 <link rel="stylesheet" href="../uber/uber_shared.css">

	17 <link rel="stylesheet" href="css/pack_item_overlay.css">

	18 <link rel="stylesheet" href="css/items.css">

19	19

20 <script src="js/main_scripts.js"></script>	20 <script src="js/main_scripts.js"></script>

21 </head>	21 </head>

22 <body>	22 <body>

23 <div id="overlay" class="overlay" hidden>	23 <div id="overlay" class="overlay" hidden>

24 <include src="pack_item_overlay.html">	24 <include src="pack_item_overlay.html">

25 <include src="../../../../ui/webui/resources/html/alert_overlay.html">	25 <include src="../../../../ui/webui/resources/html/alert_overlay.html">

26 </div>	26 </div>

27 <div class="page" id="extension-settings">	27 <div class="page" id="extension-settings">

28 <h1 i18n-content="appsDevtoolTitle"></h1>

29 <tabbox id="tab-box">	28 <tabbox id="tab-box">

30 <tabs id="tabs">	29 <div id="header">

31 <tab i18n-content="appsDevtoolApps"></tab>	30 <div id="developer-controls">

32 <tab i18n-content="appsDevtoolExtensions"></tab>	31 <button id="load-unpacked"

33 </tabs>	32 i18n-content="appsDevtoolLoadUnpackedButton"></button>
	Dan Beam 2013/05/23 23:06:48 4 \s indent or lining up attributes -- be consiste 4 \s indent or lining up attributes -- be consistent (below you use 4 \s, here you're lining up) dvh 2013/05/24 04:33:42 Done. Show quoted text On 2013/05/23 23:06:48, Dan Beam wrote: > 4 \s indent or lining up attributes -- be consistent (below you use 4 \s, here > you're lining up) Done.
34 <div id="developer-controls">	33 <button id="pack-item" i18n-content="appsDevtoolPackButton">

35 <button id="load-unpacked"	34 </button>

36 i18n-content="appsDevtoolLoadUnpackedButton"></button>	35 <button id="update-items-now"

37 <button id="pack-item"	36 i18n-content="appsDevtoolUpdateButton">

38 i18n-content="appsDevtoolPackButton"></button>	37 </button>

39 <button id= "update-items-now"	38 <h1 id="header-title" i18n-content="appsDevtoolTitle"></h1>

40 i18n-content="appsDevtoolUpdateButton"></button>	39 <input id="search" type="text"

41 <input id="search" type="text"	40 i18n-values=".placeholder:appsDevtoolSearch" spellcheck="false"

42 i18n-values=".placeholder:appsDevtoolSearch" spellcheck="false">	41 placeholder="Search">
	Dan Beam 2013/05/23 23:06:48 l10n? l10n? dvh 2013/05/24 04:33:42 I removed placeholder="Search". I think that's a g Show quoted text On 2013/05/23 23:06:48, Dan Beam wrote: > l10n? I removed placeholder="Search". I think that's a glitch.
43 <hr>	42 </div>

44 </div>	43 <div id="tabs-header-container">

	44 <tabs id="tabs" tabindex="0">

	45 <tab i18n-content="appsDevtoolApps"></tab>

	46 <tab i18n-content="appsDevtoolExtensions"></tab>

	47 </tabs>

	48 </div>

	49 <div id="header-bottom-gradient">
	Dan Beam 2013/05/23 23:06:48 nit: <div id="header-bottom-gradient"></div> nit: <div id="header-bottom-gradient"></div> dvh 2013/05/24 04:33:42 Done. Show quoted text On 2013/05/23 23:06:48, Dan Beam wrote: > nit: <div id="header-bottom-gradient"></div> Done.
	50 </div>

	51 </div> <!-- #header -->
	Dan Beam 2013/05/23 23:06:48 ^ we don't really have a precedent for <!-- doing ^ we don't really have a precedent for <!-- doing this -->, but I guess it's OK... dvh 2013/05/24 04:33:42 I'll remove that anyway. Show quoted text On 2013/05/23 23:06:48, Dan Beam wrote: > ^ we don't really have a precedent for <!-- doing this -->, but I guess it's > OK... I'll remove that anyway.
45 <tabpanels id="tab-panels">	52 <tabpanels id="tab-panels">

46 <!-- Apps Tab -->	53 <!-- Apps Tab -->

47 <tabpanel id="apps-tab">	54 <tabpanel id="apps-tab">

48 <div id="app-settings-list" class="empty-extension-list">	55 <div id="app-settings-list" class="empty-extension-list">

49 </div>	56 </div>

50 <div id="no-apps">	57 <div id="no-apps">

51 <span id="no-apps-message"	58 <span id="no-apps-message"

52 i18n-content="appsDevtoolNoApps"></span>	59 i18n-content="appsDevtoolNoApps"></span>

53 </div>	60 </div>

54 </tabpanel>	61 </tabpanel>

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
142 </label>	149 </label>

143 <span class="location-text"></span>	150 <span class="location-text"></span>

144 </div>	151 </div>

145 </div>	152 </div>

146 </div>	153 </div>

147 </div>	154 </div>

148 <include src="../../../../ui/webui/resources/html/trash.html">	155 <include src="../../../../ui/webui/resources/html/trash.html">

149 </div>	156 </div>

150 </body>	157 </body>

151 </html>	158 </html>

OLD	NEW