Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2248)

Unified Diff: chrome/browser/resources/apps_debugger/css/items.css

Issue 15389003: Loosen a bit the HTML hierarchy required for Tabs to work, Improved UX of the dev tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed call to console.trace() Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/apps_debugger/css/items.css
diff --git a/chrome/browser/resources/apps_debugger/css/items.css b/chrome/browser/resources/apps_debugger/css/items.css
index 6b4e990b94a0b6eabdaa170c511589f26165e056..5a483aad419b9ef9e162a65e73da9166f6a5ff39 100644
--- a/chrome/browser/resources/apps_debugger/css/items.css
+++ b/chrome/browser/resources/apps_debugger/css/items.css
@@ -17,34 +17,114 @@ hr {
/* Override the visual style of tabs. */
+#tabs-header-container {
+ border-bottom: 1px solid #e0e0e0;
+ height: calc(100% - 53px);
+}
+
+#tabs {
+ border-bottom: none;
+ margin: 5px auto 0 auto;
Dan Beam 2013/05/23 23:06:48 5px auto 0
dvh 2013/05/24 04:33:42 Done.
+ padding: 0 5px;
+ width: 800px;
+}
+
tabs tab {
+ border-color: #e0e0e0;
min-width: 150px;
padding: 5px 20px;
}
-/* Contents */
+tabs > [selected] {
+ background: white;
+ border-color: #e0e0e0;
+}
-#extension-settings {
- margin: 30px;
- max-width: 800px;
+html.focus-outline-visible tabs:focus > [selected] {
+ background: white;
+ border-color: rgb(160, 160, 255);
+ outline: none;
}
-#no-extensions-message,
-#no-apps-message {
- font-weight: bold;
+tabs > :not([selected]) {
+ background: none;
+ border-color: #e0e0e0;
}
-.empty-item-list {
- height: 3em;
+tabs > :not([selected]):hover {
+ background: rgba(255, 255, 255, 0.9);
+}
+
+tabpanels {
+ height: 100%;
+ padding: 0;
+ width: 100%;
+}
+
+tabpanel {
+ margin: 0 auto;
+ padding-top: 80px;
+ width: 800px;
+}
+
+/* Header */
+
+#header {
+ background-color: rgba(255, 255, 255, 0.9);
+ position: fixed;
+ top: 0;
+ width: 100%;
+ z-index: 1;
}
#developer-controls {
- margin-top: 15px;
- max-width: 750px;
+ margin-top: 0;
+ max-width: none;
+ padding: 3px 10px 8px 10px;
Dan Beam 2013/05/23 23:06:48 3px 10px 8px
dvh 2013/05/24 04:33:42 Done.
+ width: calc(100% - 20px);
+}
+
+#header-title {
+ display: inline-block;
+ font-size: 1.2em;
+ margin-left: 50px;
Dan Beam 2013/05/23 23:06:48 RTL? -webkit-margin-start: 50px; might be what you
dvh 2013/05/24 04:33:42 Done.
+ position: relative;
+ top: 3px;
Dan Beam 2013/05/23 23:06:48 ^ why are you using relative + top? wouldn't marg
dvh 2013/05/24 04:33:42 I just tried it and since buttons and the header-t
+}
+
+#header-bottom-gradient {
+ background: linear-gradient(to bottom, rgba(255, 255, 255, 1.0),
Dan Beam 2013/05/23 23:06:48 does this work without -webkit? also rgba(255, 255
dvh 2013/05/24 04:33:42 I found that it works in practice. http://dev.w3.
+ rgba(255, 255, 255, 0));
+ height: 30px;
+ left: 0;
Dan Beam 2013/05/23 23:06:48 RTL? just adding right: 0; may be enough...
dvh 2013/05/24 04:33:42 Removed left:0.
+ position: fixed;
Dan Beam 2013/05/23 23:06:48 ^ does this app ever scroll?
dvh 2013/05/24 04:33:42 The "toolbar" + the gradient at the bottom of the
+ top: 80px;
+ width: 100%;
}
#search {
float: right;
+ margin-right: 0;
Dan Beam 2013/05/23 23:06:48 ^ RTL
dvh 2013/05/24 04:33:42 I removed "margin-right: 0". I'll investigate "flo
+ margin-top: 7px;
+ padding: 4px;
+ width: 200px;
+}
+
+/* Contents */
+
+#extension-settings {
+ margin: 0;
+ max-width: 100%;
+ padding: 10px 0;
+}
+
+#no-extensions-message,
+#no-apps-message {
+ font-weight: bold;
+}
+
+.empty-item-list {
+ height: 3em;
}
html[dir='rtl'] #search {

Powered by Google App Engine
This is Rietveld 408576698