Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1538883003: remove internal streaming of results, remove obsolete test, cleanup unused code (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove internal streaming of results, remove obsolete test, cleanup unused code R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/39d5abb66233bf5230c5ff94a9626fab58b58780

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -519 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +17 lines, -24 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 4 chunks +10 lines, -34 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +14 lines, -46 lines 0 comments Download
M pkg/analysis_server/test/completion_test_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +2 lines, -414 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-18 15:10:34 UTC) #2
scheglov
LGTM
5 years ago (2015-12-18 15:51:25 UTC) #3
danrubel
5 years ago (2015-12-18 15:52:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
39d5abb66233bf5230c5ff94a9626fab58b58780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698