remove internal streaming of results, remove obsolete test, cleanup unused code

pkg/analysis_server/lib/src/domain_completion.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.completion;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
 import 'package:analysis_server/src/analysis_server.dart';
@@ skipping 189 matching lines @@
           ' but found ${params.offset}');
     }
 
     // schedule completion analysis
     recordRequest(performance, context, source, params.offset);
     if (manager == null) {
       manager = completionManagerFor(context, source);
     }
     CompletionRequest completionRequest = new CompletionRequestImpl(context,
         server.resourceProvider, server.searchEngine, source, params.offset);
-    int notificationCount = 0;
     String completionId = (_nextCompletionId++).toString();
-    manager.results(completionRequest).listen((CompletionResult result) {
-      ++notificationCount;
-      bool isLast = result is CompletionResultImpl ? result.isLast : true;
-      performance.logElapseTime("notification $notificationCount send", () {
-        sendCompletionNotification(completionId, result.replacementOffset,
-            result.replacementLength, result.suggestions, isLast);
-      });
-      if (notificationCount == 1) {
-        performance.logFirstNotificationComplete('notification 1 complete');
-        performance.suggestionCountFirst = result.suggestions.length;
-      }
-      if (isLast) {
-        performance.notificationCount = notificationCount;
-        performance.suggestionCountLast = result.suggestions.length;
-        performance.complete();
-      }
+    manager
+        .computeSuggestions(completionRequest)
+        .then((CompletionResult result) {
+      const SEND_NOTIFICATION_TAG = 'send notification';
+      performance.logStartTime(SEND_NOTIFICATION_TAG);
+      sendCompletionNotification(completionId, result.replacementOffset,
+          result.replacementLength, result.suggestions);
+      performance.logElapseTime(SEND_NOTIFICATION_TAG);
+
+      performance.notificationCount = 1;
+      performance.logFirstNotificationComplete('notification 1 complete');
+      performance.suggestionCountFirst = result.suggestions.length;
+      performance.suggestionCountLast = result.suggestions.length;
+      performance.complete();
     });
     // initial response without results
     return new CompletionGetSuggestionsResult(completionId)
         .toResponse(request.id);
   }
 
   /**
    * If tracking code completion performance over time, then
    * record addition information about the request in the performance record.
    */
@@ skipping 10 matching lines @@
     performance.setContentsAndOffset(data.data, offset);
     while (performanceList.length >= performanceListMaxLength) {
       performanceList.removeAt(0);
     }
     performanceList.add(performance);
   }
 
   /**
    * Send completion notification results.
    */
-  void sendCompletionNotification(
-      String completionId,
-      int replacementOffset,
-      int replacementLength,
-      Iterable<CompletionSuggestion> results,
-      bool isLast) {
+  void sendCompletionNotification(String completionId, int replacementOffset,
+      int replacementLength, Iterable<CompletionSuggestion> results) {
     server.sendNotification(new CompletionResultsParams(
-            completionId, replacementOffset, replacementLength, results, isLast)
+            completionId, replacementOffset, replacementLength, results, true)
         .toNotification());
   }
 
   /**
    * Discard the cache if a source other than the source referenced by
    * the cache changes or if any source is added, removed, or deleted.
    */
   void sourcesChanged(SourcesChangedEvent event) {
     bool shouldDiscardManager(SourcesChangedEvent event) {
       if (_manager == null) {
@@ skipping 20 matching lines @@
     if (_sourcesChangedSubscription != null) {
       _sourcesChangedSubscription.cancel();
       _sourcesChangedSubscription = null;
     }
     if (_manager != null) {
       _manager.dispose();
       _manager = null;
     }
   }
 }