Update SkPictureRecord to allow some ops to be written separately

src/core/SkPictureRecord.h

Index: src/core/SkPictureRecord.h
===================================================================
--- src/core/SkPictureRecord.h	(revision 13297)
+++ src/core/SkPictureRecord.h	(working copy)
@@ -108,9 +108,8 @@
 
 private:
     void handleOptimization(int opt);
-    void recordRestoreOffsetPlaceholder(SkRegion::Op);
-    void fillRestoreOffsetPlaceholdersForCurrentStackLevel(
-        uint32_t restoreOffset);
+    int recordRestoreOffsetPlaceholder(SkRegion::Op);

[reed1, 2014/02/04 15:47:17]

not new, but soon we should start adding dox to these internal methods, since
this stuff is already hard to understand...

[robertphillips, 2014/02/04 19:08:01]

I will keep this in mind. If the collapsing code sticks the entire offset
recording system will change.

+    void fillRestoreOffsetPlaceholdersForCurrentStackLevel(uint32_t restoreOffset);
 
     SkTDArray<int32_t> fRestoreOffsetStack;
     int fFirstSavedLayerIndex;
@@ -165,6 +164,7 @@
     const SkFlatData* addPaint(const SkPaint& paint) { return this->addPaintPtr(&paint); }
     const SkFlatData* addPaintPtr(const SkPaint* paint);
     void addFlatPaint(const SkFlatData* flatPaint);
+    int addPathToHeap(const SkPath& path);
     void addPath(const SkPath& path);
     void addPicture(SkPicture& picture);
     void addPoint(const SkPoint& point);
@@ -237,6 +237,16 @@
                           const SkScalar xpos[], SkScalar constY,
                           const SkPaint& paint, const SkFlatData* flatPaintData);
 
+    void concatImpl(const SkMatrix& matrix);

[reed1, 2014/02/04 15:47:17]

block comment as to why we have these "helpers"?

[robertphillips, 2014/02/04 19:08:01]

Done.

+    int clipRectImpl(const SkRect& rect, SkRegion::Op op, bool doAA);
+    int clipRRectImpl(const SkRRect& rrect, SkRegion::Op op, bool doAA);
+    int clipPathImpl(int pathID, SkRegion::Op op, bool doAA);
+    int clipRegionImpl(const SkRegion& region, SkRegion::Op op);
+    void saveImpl(SaveFlags flags);
+    void saveLayerImpl(const SkRect* bounds, const SkPaint* paint,
+                       SaveFlags flags);
+    void restoreImpl();
+
     // These are set to NULL in our constructor, but may be changed by
     // subclasses, in which case they will be SkSafeUnref'd in our destructor.
     SkBBoxHierarchy* fBoundingHierarchy;