Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1538823002: Convert Pass()→std::move() in mojo/ (Closed)

Created:
5 years ago by dcheng
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //mojo BUG=557422 R=avi@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/6196e1f23f37c8e7196bf1e2263ae985b3e89f0c Cr-Commit-Position: refs/heads/master@{#366168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -331 lines) Patch
M mojo/application/public/cpp/application_connection.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/application_impl.h View 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/application/public/cpp/connect.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/lib/application_impl.cc View 7 chunks +18 lines, -18 lines 0 comments Download
M mojo/application/public/cpp/lib/application_test_base.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/application/public/cpp/lib/content_handler_factory.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M mojo/application/public/cpp/lib/interface_factory_connector.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/application/public/cpp/lib/service_connector_registry.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/lib/service_provider_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/application/public/cpp/lib/service_registry.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M mojo/common/common_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/data_pipe_drainer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/common/data_pipe_utils.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/common/weak_binding_set.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/common/weak_interface_ptr_set.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/converters/blink/blink_input_events_type_converters.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M mojo/converters/geometry/geometry_type_converters.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 10 chunks +14 lines, -12 lines 0 comments Download
M mojo/converters/network/network_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 25 chunks +33 lines, -31 lines 0 comments Download
M mojo/converters/surfaces/surfaces_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/tests/surface_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M mojo/converters/transform/transform_type_converters.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/fetcher/about_fetcher.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/fetcher/about_fetcher_unittest.cc View 7 chunks +10 lines, -7 lines 0 comments Download
M mojo/fetcher/data_fetcher.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/fetcher/data_fetcher_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/fetcher/local_fetcher.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/fetcher/network_fetcher.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M mojo/fetcher/network_fetcher_unittest.cc View 7 chunks +10 lines, -7 lines 0 comments Download
M mojo/fetcher/update_fetcher.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M mojo/gles2/gles2_context.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/message_pump/handle_watcher_perftest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/message_pump/handle_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/package_manager/capability_filter_content_handler_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M mojo/package_manager/content_handler_connection.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M mojo/package_manager/content_handler_unittest.cc View 11 chunks +13 lines, -11 lines 0 comments Download
M mojo/package_manager/package_manager_impl.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M mojo/platform_handle/platform_handle_functions.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/runner/child/native_apptest_target.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/runner/child/runner_connection.cc View 7 chunks +12 lines, -10 lines 0 comments Download
M mojo/runner/child/test_native_main.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/runner/context.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M mojo/runner/host/child_process.cc View 7 chunks +13 lines, -10 lines 0 comments Download
M mojo/runner/host/child_process_host.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M mojo/runner/host/in_process_native_runner.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/runner/host/out_of_process_native_runner.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/runner/task_runners.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/tracer.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/shell/application_instance.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M mojo/shell/application_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/shell/application_manager.cc View 13 chunks +24 lines, -22 lines 0 comments Download
M mojo/shell/application_manager_apptest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 13 chunks +18 lines, -14 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M mojo/shell/connect_to_application_params.h View 2 chunks +12 lines, -5 lines 0 comments Download
M mojo/shell/connect_to_application_params.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/shell/connect_util.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/shell/connect_util.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/shell/shell_application_delegate.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M mojo/shell/shell_application_loader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/shell/static_application_loader.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dcheng
5 years ago (2015-12-18 09:13:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538823002/1
5 years ago (2015-12-18 09:14:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 10:14:24 UTC) #7
Avi (use Gerrit)
stampity stamp lgtm
5 years ago (2015-12-18 20:58:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538823002/1
5 years ago (2015-12-18 20:59:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 21:08:29 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-18 21:10:09 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6196e1f23f37c8e7196bf1e2263ae985b3e89f0c
Cr-Commit-Position: refs/heads/master@{#366168}

Powered by Google App Engine
This is Rietveld 408576698