Supporting high dpi favicons in Instant Extended.

chrome/common/favicon_types.h

Index: chrome/common/favicon_types.h
diff --git a/chrome/common/favicon_types.h b/chrome/common/favicon_types.h
new file mode 100644
index 0000000000000000000000000000000000000000..ca583985696ee4cd012a54206bd42517f09f5936
--- /dev/null
+++ b/chrome/common/favicon_types.h
@@ -0,0 +1,24 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_FAVICON_TYPES_H_
+#define CHROME_COMMON_FAVICON_TYPES_H_
+
+namespace chrome {
+
+// Defines the icon types. They are also stored in icon_type field of favicons

[James Hawkins, 2013/06/27 21:44:32]

Why is this in chrome/common?

[pedro (no code reviews), 2013/06/27 23:02:47]

This used to be in chrome/browser/favicon, but we need to access it from
chrome/renderer/searchbox in order to support hi dpi favicons in Instant
Extended.

Samarth suggested moving the entire chrome/browser/favicon/favicon_types.h file
to chrome/common (or chrome/common/favicon as Steven suggested) so all favicon
related types would be in a single place. What do you think?

[James Hawkins, 2013/06/27 23:04:40]

That's fine.

+// table.
+// The values of the IconTypes are used to select the priority in which favicon
+// data is returned in HistoryBackend and ThumbnailDatabase. Data for the
+// largest IconType takes priority if data for multiple IconTypes is available.
+enum IconType {
+  INVALID_ICON = 0x0,
+  FAVICON = 1 << 0,
+  TOUCH_ICON = 1 << 1,
+  TOUCH_PRECOMPOSED_ICON = 1 << 2
+};
+
+}  // namespace chrome
+
+#endif  // CHROME_COMMON_FAVICON_TYPES_H_