chrome/common/favicon_types.h - Issue 15388002: Supporting high dpi favicons in Instant Extended.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/favicon_types.h

Issue 15388002: Supporting high dpi favicons in Instant Extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_FAVICON_TYPES_H_

	6 #define CHROME_COMMON_FAVICON_TYPES_H_

	7

	8 namespace chrome {

	9

	10 // Defines the icon types. They are also stored in icon_type field of favicons
	James Hawkins 2013/06/27 21:44:32 Why is this in chrome/common? Why is this in chrome/common? pedro (no code reviews) 2013/06/27 23:02:47 This used to be in chrome/browser/favicon, but we Show quoted text On 2013/06/27 21:44:32, James Hawkins wrote: > Why is this in chrome/common? This used to be in chrome/browser/favicon, but we need to access it from chrome/renderer/searchbox in order to support hi dpi favicons in Instant Extended. Samarth suggested moving the entire chrome/browser/favicon/favicon_types.h file to chrome/common (or chrome/common/favicon as Steven suggested) so all favicon related types would be in a single place. What do you think? James Hawkins 2013/06/27 23:04:40 That's fine. Show quoted text On 2013/06/27 23:02:47, pedrosimonetti wrote: > On 2013/06/27 21:44:32, James Hawkins wrote: > > Why is this in chrome/common? > > This used to be in chrome/browser/favicon, but we need to access it from > chrome/renderer/searchbox in order to support hi dpi favicons in Instant > Extended. > > Samarth suggested moving the entire chrome/browser/favicon/favicon_types.h file > to chrome/common (or chrome/common/favicon as Steven suggested) so all favicon > related types would be in a single place. What do you think? That's fine.
	11 // table.

	12 // The values of the IconTypes are used to select the priority in which favicon

	13 // data is returned in HistoryBackend and ThumbnailDatabase. Data for the

	14 // largest IconType takes priority if data for multiple IconTypes is available.

	15 enum IconType {

	16 INVALID_ICON = 0x0,

	17 FAVICON = 1 << 0,

	18 TOUCH_ICON = 1 << 1,

	19 TOUCH_PRECOMPOSED_ICON = 1 << 2

	20 };

	21

	22 } // namespace chrome

	23

	24 #endif // CHROME_COMMON_FAVICON_TYPES_H_

OLD	NEW

« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/favicon_url_parser.h » ('j') | no next file with comments »