Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1538463002: Revert of Forward the number of skipped frames by the OS in audio playout. (Closed)

Created:
5 years ago by Henrik Grunell
Modified:
5 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org, o1ka, kmackay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Forward the number of skipped frames by the OS in audio playout. (patchset #10 id:180001 of https://codereview.chromium.org/1487983002/ ) Reason for revert: Causes crackling sound on all ChromeOS boards. Original issue's description: > Forward the number of skipped frames by the OS in audio playout. > > * Only for Mac. > > Will be done in follow-up CLs: > * Windows. > * Hooking this up to the AEC. > > BUG=560371 > > Committed: https://crrev.com/db03a8d1128783ff4803364ba616ae5fac8822f7 > Cr-Commit-Position: refs/heads/master@{#364990} TBR=tommi@chromium.org,dalecurtis@chromium.org,olka@chromium.org,gunsch@chromium.org,ckehoe@chromium.org,dtseng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560371, 570060 Committed: https://crrev.com/c03d9fa3fb213991e0e2abbcff8f66e5cfc55eeb Cr-Commit-Position: refs/heads/master@{#365783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -302 lines) Patch
M chromecast/media/audio/cast_audio_output_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/audio_modem/audio_player_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/audio_modem/audio_player_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/audio_modem/audio_player_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_audio_muter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M content/renderer/media/audio_track_recorder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_recorder_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/renderer_webaudiodevice_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/renderer_webaudiodevice_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_renderer.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_renderer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/alsa/alsa_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/alsa/alsa_output_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/android/audio_android_unittest.cc View 5 chunks +7 lines, -13 lines 0 comments Download
M media/audio/android/opensles_output.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_device_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_input_device.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_io.h View 1 chunk +1 line, -4 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/audio/audio_output_controller.h View 3 chunks +3 lines, -10 lines 0 comments Download
M media/audio/audio_output_controller.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/audio/audio_output_device.cc View 3 chunks +14 lines, -26 lines 0 comments Download
M media/audio/audio_output_device_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M media/audio/audio_output_stream_sink.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/audio/audio_output_stream_sink.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/audio/audio_parameters.h View 2 chunks +7 lines, -18 lines 0 comments Download
M media/audio/clockless_audio_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/cras/cras_unified.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/cras/cras_unified_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/audio/fake_audio_input_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac.h View 2 chunks +0 lines, -7 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M media/audio/mac/audio_auhal_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mock_audio_source_callback.h View 1 chunk +2 lines, -4 lines 0 comments Download
M media/audio/null_audio_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/pulse/pulse_output.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/simple_sources.h View 3 chunks +3 lines, -9 lines 0 comments Download
M media/audio/simple_sources.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M media/audio/simple_sources_unittest.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M media/audio/sounds/audio_stream_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M media/audio/virtual_audio_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 6 chunks +13 lines, -20 lines 0 comments Download
M media/audio/win/waveout_output_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/audio_bus_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_hash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_renderer_mixer.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/base/audio_renderer_mixer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/base/audio_renderer_mixer_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_renderer_mixer_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/base/audio_renderer_sink.h View 1 chunk +2 lines, -5 lines 0 comments Download
M media/base/fake_audio_render_callback.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/base/fake_audio_render_callback.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/fake_audio_renderer_sink.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/base/fake_audio_renderer_sink.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webaudiosourceprovider_impl_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/cast/test/utility/audio_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/audio_renderer_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Henrik Grunell
Created Revert of Forward the number of skipped frames by the OS in audio playout.
5 years ago (2015-12-17 08:20:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538463002/1
5 years ago (2015-12-17 08:22:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 08:24:15 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 08:25:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c03d9fa3fb213991e0e2abbcff8f66e5cfc55eeb
Cr-Commit-Position: refs/heads/master@{#365783}

Powered by Google App Engine
This is Rietveld 408576698