Issue 1538443003: Add mls instruction to the ARM integrated assembler.

Issue 1538443003: Add mls instruction to the ARM integrated assembler. (Closed)

Created:
5 years ago by Karl

Modified:
5 years ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add mls instruction to the ARM integrated assembler. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a990f0c58921d886976e409e170f6c8ee40e9a23

Patch Set 2 : Update DART sources. #

Total comments: 2

Patch Set 3 : Fix nit. #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -13 lines)			Patch
M	src/DartARM32/assembler_arm.h	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/DartARM32/assembler_arm.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/IceAssemblerARM32.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/IceAssemblerARM32.cpp	View		1 chunk	+20 lines, -2 lines	0 comments	Download
M	src/IceInstARM32.cpp	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	tests_lit/assembler/arm32/mls.ll	View	1 2	1 chunk	+112 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

lgtm https://codereview.chromium.org/1538443003/diff/20001/tests_lit/assembler/arm32/mls.ll File tests_lit/assembler/arm32/mls.ll (right): https://codereview.chromium.org/1538443003/diff/20001/tests_lit/assembler/arm32/mls.ll#newcode1 tests_lit/assembler/arm32/mls.ll:1: ; Show that we know how to translate ...

5 years ago (2015-12-17 19:29:58 UTC) #4

Karl

Committed patchset #3 (id:40001) manually as a990f0c58921d886976e409e170f6c8ee40e9a23 (presubmit successful).

5 years ago (2015-12-18 15:36:06 UTC) #6

Karl

5 years ago (2015-12-18 15:36:35 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/1538443003/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/mls.ll (right):

https://codereview.chromium.org/1538443003/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mls.ll:1: ; Show that we know how to translate clz.
On 2015/12/17 19:29:57, stichnot wrote:
> mls

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages