Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1538443003: Add mls instruction to the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.h
diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h
index bf6bc11aa39337d7a5e1fa66dd984ddaa09674e6..8e7cc337b1f1e63c34d7ebdef3e26c00a8d5562f 100644
--- a/src/DartARM32/assembler_arm.h
+++ b/src/DartARM32/assembler_arm.h
@@ -140,9 +140,7 @@ class Operand : public ValueObject {
type_ = 1;
encoding_ = immediate;
}
-#endif
-#if 0
// Moved to decodeOperand() and encodeRotatedImm8() in IceAssemblerARM32.cpp
// Data-processing operands - Rotated immediate.
Operand(uint32_t rotate, uint32_t immed8) {
@@ -450,9 +448,7 @@ class Assembler : public ValueObject {
// Moved to ARM32::AssemblerARM32::and_()
// Data-processing instructions.
void and_(Register rd, Register rn, Operand o, Condition cond = AL);
-#endif
-#if 0
// Moved to ARM32::AssemblerARM32::eor()
void eor(Register rd, Register rn, Operand o, Condition cond = AL);
@@ -503,9 +499,7 @@ class Assembler : public ValueObject {
// Moved to ARM32::IceAssemblerARM32::mov()
void mov(Register rd, Operand o, Condition cond = AL);
void movs(Register rd, Operand o, Condition cond = AL);
-#endif
-#if 0
// Moved to ARM32::IceAssemblerARM32::bic()
void bic(Register rd, Register rn, Operand o, Condition cond = AL);
void bics(Register rd, Register rn, Operand o, Condition cond = AL);
@@ -527,11 +521,14 @@ class Assembler : public ValueObject {
// Moved to ARM32::AssemblerARM32::mla()
void mla(Register rd, Register rn, Register rm, Register ra,
Condition cond = AL);
-#endif
+ // Moved to ARM32::AssemblerARM32::mls()
void mls(Register rd, Register rn, Register rm, Register ra,
Condition cond = AL);
+#endif
+
void smull(Register rd_lo, Register rd_hi, Register rn, Register rm,
Condition cond = AL);
+
#if 0
// Moved to ARM32::AssemblerARM32::umull();
void umull(Register rd_lo, Register rd_hi, Register rn, Register rm,
@@ -564,10 +561,12 @@ class Assembler : public ValueObject {
void ldrb(Register rd, Address ad, Condition cond = AL);
// Moved to ARM32::AssemblerARM32::str()
void strb(Register rd, Address ad, Condition cond = AL);
-#endif
+ // Moved to ARM32::AssemblerARM32::ldr()
void ldrh(Register rd, Address ad, Condition cond = AL);
+ // Moved to ARM32::AssemblerARM32::str()
void strh(Register rd, Address ad, Condition cond = AL);
+#endif
void ldrsb(Register rd, Address ad, Condition cond = AL);
void ldrsh(Register rd, Address ad, Condition cond = AL);
@@ -597,6 +596,7 @@ class Assembler : public ValueObject {
// Miscellaneous instructions.
void clrex();
+
#if 0
// Moved to ARM32::AssemblerARM32::nop().
void nop(Condition cond = AL);
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698