Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1538343002: SampleApp: remove Picture_DeviceType (Closed)

Created:
5 years ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
bsalomon, joshua.litt, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SampleApp: remove Picture_DeviceType Remove Picture_DeviceType from SampleApp SampleWindow DeviceType enumeration. Use a bool variable to control whether the drawing happens via MultiPictureDraw. The MultiPictureDraw mode can be activated by 'M', and title is updated to contain "<MPD>". Previously the MPD mode was inaccessible. This works towards removing backend specific code from SampleApp and VisualBench with the aim to move the code to the common SkView framework (SkWindow in particular). The grand goal is to be able to use command buffer GPU API and NVPR in these apps. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1538343002 Committed: https://skia.googlesource.com/skia/+/8686a5eeef85bbd28404d7cc51b5d02ceff35767

Patch Set 1 #

Patch Set 2 : Missing picture devicetype mention #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M experimental/iOSSampleApp/SkSampleUIView.mm View 2 chunks +0 lines, -4 lines 0 comments Download
M samplecode/SampleApp.h View 2 chunks +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 10 chunks +33 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Kimmo Kinnunen
I wonder who would be able to say if this kind of work would be ...
5 years ago (2015-12-21 13:44:36 UTC) #3
reed1
nice change. LGTM
4 years, 11 months ago (2016-01-04 16:06:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538343002/40001
4 years, 11 months ago (2016-01-05 07:50:40 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 08:04:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8686a5eeef85bbd28404d7cc51b5d02ceff35767

Powered by Google App Engine
This is Rietveld 408576698