Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1549483002: SampleApp: Build list of devices dynamically

Created:
5 years ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@sampleapp-01-no-picturedevice
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SampleApp: Build list of devices dynamically Build list of devices available to SampleApp user dynamically. This works around the problem that in the future, there might be more device configurations than device type enumerations. Concretely, the configurable properties could be msaa sample count, nvpr or not, as well as API type. SkOSMenu used varargs, which selects the number of entries during compile time very rigidly. Change it to use SkTArray. Changes '--gpu' to '--startWith gpu' BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1549483002

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -131 lines) Patch
M include/views/SkOSMenu.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.h View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 6 7 8 9 20 chunks +89 lines, -116 lines 0 comments Download
M src/views/SkOSMenu.cpp View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Kimmo Kinnunen
4 years, 11 months ago (2016-01-05 08:33:31 UTC) #3
Kimmo Kinnunen
4 years, 11 months ago (2016-01-15 12:54:42 UTC) #5
PTAL if  possible.

Powered by Google App Engine
This is Rietveld 408576698