Issue 153823010: Remove useless check from WorkspaceLayoutManager::ShowTypeChanged()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153823010: Remove useless check from WorkspaceLayoutManager::ShowTypeChanged() (Closed)

Created:
6 years, 10 months ago by pkotwicz

Modified:
6 years, 10 months ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove useless check from WorkspaceLayoutManager::ShowTypeChanged() Since https://codereview.chromium.org/99303006 WorkspaceLayoutManager::OnWindowShowTypeChanged() is only called when the show type has changed. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250688

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	ash/wm/workspace/workspace_layout_manager.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/153823010/1

6 years, 10 months ago (2014-02-12 05:03:04 UTC) #4

Message was sent while issue was closed.

Change committed as 250688