Do not send the OnWindowShowTypeChanged() notification if the show type has not changed

Do not send the OnWindowShowTypeChanged() notification if the window show type has not changed

BUG=None
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240151

[pkotwicz, 2013-12-09 22:29:03]

Oshima, can you please take a look?

https://codereview.chromium.org/99303006/diff/70001/ash/wm/window_state.cc
File ash/wm/window_state.cc (left):

https://codereview.chromium.org/99303006/diff/70001/ash/wm/window_state.cc#ol...
ash/wm/window_state.cc:181: void WindowState::Restore() {
I removed this code because it is not helpful. In particular, it does not get
trigged via views::Widget::Restore().

https://codereview.chromium.org/99303006/diff/70001/ash/wm/window_state.cc#ol...
ash/wm/window_state.cc:268: // TODO(oshima): Notify only when the state has
changed.
I actually did not find any tests which are broken because of this

[pkotwicz, 2013-12-09 22:43:07]

Actually, can you hold off on the review. I need to fix
SnapSizerTest.MinimumSize

[oshima, 2013-12-09 23:00:34]

On 2013/12/09 22:43:07, pkotwicz wrote:
> Actually, can you hold off on the review. I need to fix
> SnapSizerTest.MinimumSize

You may want to run all tests (if you haven't already done so. IIRC, there were
more than one failure. they could have been fixed though)

[pkotwicz, 2013-12-10 18:26:50]

Oshima, can you please take another look? I have run all of the tests

[oshima, 2013-12-10 22:02:24]

lgtm with nits.

https://codereview.chromium.org/99303006/diff/90001/ash/wm/window_state.cc
File ash/wm/window_state.cc (right):

https://codereview.chromium.org/99303006/diff/90001/ash/wm/window_state.cc#ne...
ash/wm/window_state.cc:286: LOG(ERROR) << "Set show type " << bounds.ToString();
remove log

https://codereview.chromium.org/99303006/diff/90001/ash/wm/window_util.cc
File ash/wm/window_util.cc (right):

https://codereview.chromium.org/99303006/diff/90001/ash/wm/window_util.cc#new...
ash/wm/window_util.cc:61: if (window_state->IsMaximizedOrFullscreen())
Can you list allowed states instead? I thin it's safer (it won't update the
bounds for minimzied state by accident for exampe)

[commit-bot: I haz the power, 2013-12-11 17:01:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/99303006/150001

[commit-bot: I haz the power, 2013-12-11 19:28:19]

Change committed as 240151