Implementing GATT connection/disconnect on OS X.

device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h

Index: device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h
diff --git a/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h b/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h
new file mode 100644
index 0000000000000000000000000000000000000000..11ecaaa36e41bc981fb344a94386374b21b17bf8
--- /dev/null
+++ b/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h
@@ -0,0 +1,26 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBPERIPHERAL_MAC_H_
+#define DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBPERIPHERAL_MAC_H_
+
+#include "base/mac/sdk_forward_declarations.h"
+#include "build/build_config.h"
+
+#import <CoreBluetooth/CoreBluetooth.h>
+
+// Class to mock a CBPeripheral. It is less convenient to use OCMock since
+// value of this class can change.

[msarda, 2016/02/11 10:55:39]

I do not understand this comment. What is the "value of this class"? Is the
class changing? Or its fields?

[jlebel, 2016/02/19 11:02:36]

This is a mock. To mock CBPeripheral class, for unit tests.
I don't know how to change the value of state using OCMock.

[msarda, 2016/02/22 14:01:06]

I think with OCMock, you could do something like:
  OCMStub([_peripheralMock state])
      .andDo(^(NSInvocation *invocation) {
        [invocation setReturnValue:&_peripheralState];
      });
I think using OCMock is better in a long run, but I will leave you and the owner
of this code to decide.

+@interface MockCBPeripheral : NSObject

[msarda, 2016/02/11 10:55:39]

Be very careful about using objects as mocks. As it will not respond correctly
to calls like isKindOfClass and isMemberOfClass

[jlebel, 2016/02/19 11:02:36]

Acknowledged.

[msarda, 2016/02/22 14:01:06]

Why does this object subclass NSObject and not CBPeripheral?

+
+@property(readonly) CBPeripheralState state;

[msarda, 2016/02/11 10:55:39]

Why are the other properties non-atomic and this one is not? Do you actually
synchronize the access to this property?

[jlebel, 2016/02/19 11:02:36]

Done.

+@property(nonatomic, readonly) NSUUID* identifier;
+@property(nonatomic, readonly) NSString* name;
+
+- (instancetype)initWithIdentifier:(NSUUID*)identifier;
+- (void)setStateForTesting:(CBPeripheralState)state;
+
+@end
+
+#endif  // DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBPERIPHERAL_MAC_H_