device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h - Issue 1538173003: Implementing GATT connection/disconnect on OS X.

Side by Side Diff: device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h

Issue 1538173003: Implementing GATT connection/disconnect on OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing patch Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/bluetooth/test/bluetooth_test_mac.mm ('K') | « device/bluetooth/test/bluetooth_test_mac.mm ('k') | device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm » ('j') | device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBPERIPHERAL_MAC_H_

	6 #define DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBPERIPHERAL_MAC_H_

	7

	8 #include "base/mac/sdk_forward_declarations.h"

	9 #include "build/build_config.h"

	10

	11 #import <CoreBluetooth/CoreBluetooth.h>

	12

	13 // Class to mock a CBPeripheral. It is less convenient to use OCMock since

	14 // value of this class can change.
	msarda 2016/02/11 10:55:39 I do not understand this comment. What is the "val I do not understand this comment. What is the "value of this class"? Is the class changing? Or its fields? jlebel 2016/02/19 11:02:36 This is a mock. To mock CBPeripheral class, for un Show quoted text On 2016/02/11 10:55:39, msarda wrote: > I do not understand this comment. What is the "value of this class"? Is the > class changing? Or its fields? This is a mock. To mock CBPeripheral class, for unit tests. I don't know how to change the value of state using OCMock. msarda 2016/02/22 14:01:06 I think with OCMock, you could do something like: Show quoted text On 2016/02/19 11:02:36, jlebel wrote: > On 2016/02/11 10:55:39, msarda wrote: > > I do not understand this comment. What is the "value of this class"? Is the > > class changing? Or its fields? > > This is a mock. To mock CBPeripheral class, for unit tests. > I don't know how to change the value of state using OCMock. I think with OCMock, you could do something like: OCMStub([_peripheralMock state]) .andDo(^(NSInvocation *invocation) { [invocation setReturnValue:&_peripheralState]; }); I think using OCMock is better in a long run, but I will leave you and the owner of this code to decide.
	15 @interface MockCBPeripheral : NSObject
	msarda 2016/02/11 10:55:39 Be very careful about using objects as mocks. As i Be very careful about using objects as mocks. As it will not respond correctly to calls like isKindOfClass and isMemberOfClass jlebel 2016/02/19 11:02:36 Acknowledged. Show quoted text On 2016/02/11 10:55:39, msarda wrote: > Be very careful about using objects as mocks. As it will not respond correctly > to calls like isKindOfClass and isMemberOfClass Acknowledged. msarda 2016/02/22 14:01:06 Why does this object subclass NSObject and not CBP Show quoted text On 2016/02/19 11:02:36, jlebel wrote: > On 2016/02/11 10:55:39, msarda wrote: > > Be very careful about using objects as mocks. As it will not respond correctly > > to calls like isKindOfClass and isMemberOfClass > > Acknowledged. Why does this object subclass NSObject and not CBPeripheral?
	16

	17 @property(readonly) CBPeripheralState state;
	msarda 2016/02/11 10:55:39 Why are the other properties non-atomic and this o Why are the other properties non-atomic and this one is not? Do you actually synchronize the access to this property? jlebel 2016/02/19 11:02:36 Done. Show quoted text On 2016/02/11 10:55:39, msarda wrote: > Why are the other properties non-atomic and this one is not? Do you actually > synchronize the access to this property? Done.
	18 @property(nonatomic, readonly) NSUUID* identifier;

	19 @property(nonatomic, readonly) NSString* name;

	20

	21 - (instancetype)initWithIdentifier:(NSUUID*)identifier;

	22 - (void)setStateForTesting:(CBPeripheralState)state;

	23

	24 @end

	25

	26 #endif // DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBPERIPHERAL_MAC_H_

OLD	NEW