Implementing GATT connection/disconnect on OS X.

device/bluetooth/bluetooth_low_energy_device_mac.h

Index: device/bluetooth/bluetooth_low_energy_device_mac.h
diff --git a/device/bluetooth/bluetooth_low_energy_device_mac.h b/device/bluetooth/bluetooth_low_energy_device_mac.h
index 19cbb0187e8f78ba22b36c7b8ef55bad0d1f3cb9..5bc7c688a950c9ed59996f60ae09c42f22063131 100644
--- a/device/bluetooth/bluetooth_low_energy_device_mac.h
+++ b/device/bluetooth/bluetooth_low_energy_device_mac.h
@@ -78,9 +78,6 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothLowEnergyDeviceMac
       const device::BluetoothUUID& uuid,
       const ConnectToServiceCallback& callback,
       const ConnectToServiceErrorCallback& error_callback) override;
-  void CreateGattConnection(
-      const GattConnectionCallback& callback,
-      const ConnectErrorCallback& error_callback) override;
 
   // BluetoothDeviceMac override.
   NSDate* GetLastUpdateTime() const override;
@@ -107,6 +104,19 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothLowEnergyDeviceMac
  private:
   friend class BluetoothAdapterMac;
   friend class BluetoothAdapterMacTest;
+  friend class BluetoothTestMac;
+
+  // Returns the Bluetooth adapter.
+  BluetoothAdapterMac* GetMacAdapter();
+
+  // Returns the CoreBluetooth Peripheral.
+  CBPeripheral* GetPeripheral();
+
+  // Callback used when the CoreBluetooth Peripheral is disconnected.
+  void DidDisconnectPeripheral();
+
+  // Called by the adapter when CoreBluetooth calls CBCentralManager's delegate.

[msarda, 2016/02/11 10:55:38]

I think this comment is too vague. What do you mean by "calls CBCentralManager's
delegate"? What method is called on the CBCentralManager's delegate (any
methond)?

Also in general, do not explain the internals of the implementation, but what
this method is supposed to do.

[jlebel, 2016/02/19 11:02:35]

Done.

+  void GattConnected();

[msarda, 2016/02/11 10:55:39]

I think the tendency in Chrome is to use function names like OnSomeEvent when
SomeEvent occurs. However if you prefer the objective-C style like Did (as you
use above), please be consistent and start this method with Did (maybe
DidConnectGatt, DidEstablishGattConnection etc).

[jlebel, 2016/02/19 11:02:35]

Done.

 
   // Equivalent to [peripheral_ state].  Allows compilation on OS X 10.6.
   CBPeripheralState GetPeripheralState() const;