Implementing GATT connection/disconnect on OS X.

device/bluetooth/bluetooth_low_energy_device_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DEVICE_MAC_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DEVICE_MAC_H_
 
 #if defined(OS_IOS)
 #import <CoreBluetooth/CoreBluetooth.h>
 #else  // !defined(OS_IOS)
@@ skipping 60 matching lines @@
   void Forget(const base::Closure& callback,
               const ErrorCallback& error_callback) override;
   void ConnectToService(
       const BluetoothUUID& uuid,
       const ConnectToServiceCallback& callback,
       const ConnectToServiceErrorCallback& error_callback) override;
   void ConnectToServiceInsecurely(
       const device::BluetoothUUID& uuid,
       const ConnectToServiceCallback& callback,
       const ConnectToServiceErrorCallback& error_callback) override;
-  void CreateGattConnection(
-      const GattConnectionCallback& callback,
-      const ConnectErrorCallback& error_callback) override;
 
   // BluetoothDeviceMac override.
   NSDate* GetLastUpdateTime() const override;
 
  protected:
   // BluetoothDevice override.
   std::string GetDeviceName() const override;
   void CreateGattConnectionImpl() override;
   void DisconnectGatt() override;
 
   // Updates information about the device.
   virtual void Update(CBPeripheral* peripheral,
                       NSDictionary* advertisement_data,
                       int rssi);
 
   static std::string GetPeripheralIdentifier(CBPeripheral* peripheral);
 
   // Hashes and truncates the peripheral identifier to deterministically
   // construct an address. The use of fake addresses is a temporary fix before
   // we switch to using bluetooth identifiers throughout Chrome.
   // http://crbug.com/507824
   static std::string GetPeripheralHashAddress(CBPeripheral* peripheral);
 
  private:
   friend class BluetoothAdapterMac;
   friend class BluetoothAdapterMacTest;
+  friend class BluetoothTestMac;
+
+  // Returns the Bluetooth adapter.
+  BluetoothAdapterMac* GetMacAdapter();
+
+  // Returns the CoreBluetooth Peripheral.
+  CBPeripheral* GetPeripheral();
+
+  // Callback used when the CoreBluetooth Peripheral is disconnected.
+  void DidDisconnectPeripheral();
+
+  // Called by the adapter when CoreBluetooth calls CBCentralManager's delegate.

[msarda, 2016/02/11 10:55:38]

I think this comment is too vague. What do you mean by "calls CBCentralManager's
delegate"? What method is called on the CBCentralManager's delegate (any
methond)?

Also in general, do not explain the internals of the implementation, but what
this method is supposed to do.

[jlebel, 2016/02/19 11:02:35]

Done.

+  void GattConnected();

[msarda, 2016/02/11 10:55:39]

I think the tendency in Chrome is to use function names like OnSomeEvent when
SomeEvent occurs. However if you prefer the objective-C style like Did (as you
use above), please be consistent and start this method with Did (maybe
DidConnectGatt, DidEstablishGattConnection etc).

[jlebel, 2016/02/19 11:02:35]

Done.

 
   // Equivalent to [peripheral_ state].  Allows compilation on OS X 10.6.
   CBPeripheralState GetPeripheralState() const;
 
   // CoreBluetooth data structure.
   base::scoped_nsobject<CBPeripheral> peripheral_;
 
   // RSSI value.
   int rssi_;
 
@@ skipping 12 matching lines @@
 
   // The services (identified by UUIDs) that this device provides.
   std::set<BluetoothUUID> advertised_uuids_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothLowEnergyDeviceMac);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DEVICE_MAC_H_