Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1537843002: Disabled custom fullscreen animation for entering tab fullscreen since currently it breaks Flash co… (Closed)

Created:
5 years ago by shrike
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Disabled custom fullscreen animation for entering tab fullscreen since currently it breaks Flash content. Added a fix so that the flash content is ensured to take up the entire fullscreen window when it enters fullscreen. BUG=566588 Review URL: https://codereview.chromium.org/1526533005 Cr-Commit-Position: refs/heads/master@{#365293} (cherry picked from commit b97a851fd806a4dfff555f9656a42187498ad06e) Committed: https://chromium.googlesource.com/chromium/src/+/1731f83f433f7402d54a592796a416c084947171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 5 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shrike
5 years ago (2015-12-17 22:16:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1731f83f433f7402d54a592796a416c084947171.

Powered by Google App Engine
This is Rietveld 408576698