Issue 1537843002: Disabled custom fullscreen animation for entering tab fullscreen since currently it breaks Flash co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1537843002: Disabled custom fullscreen animation for entering tab fullscreen since currently it breaks Flash co… (Closed)

Created:
5 years ago by shrike

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Disabled custom fullscreen animation for entering tab fullscreen since currently it breaks Flash content. Added a fix so that the flash content is ensured to take up the entire fullscreen window when it enters fullscreen. BUG=566588 Review URL: https://codereview.chromium.org/1526533005 Cr-Commit-Position: refs/heads/master@{#365293} (cherry picked from commit b97a851fd806a4dfff555f9656a42187498ad06e) Committed: https://chromium.googlesource.com/chromium/src/+/1731f83f433f7402d54a592796a416c084947171

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -8 lines)			Patch
	M	chrome/browser/ui/cocoa/browser_window_controller_private.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View		5 chunks	+24 lines, -8 lines	0 comments	Download

Total messages: 2 (1 generated)

shrike

5 years ago (2015-12-17 22:16:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1731f83f433f7402d54a592796a416c084947171.