Fix for Flash Content Fullscreen

Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=566588
Committed: https://crrev.com/b97a851fd806a4dfff555f9656a42187498ad06e
Cr-Commit-Position: refs/heads/master@{#365293}

[spqchan, 2015-12-15 09:08:11]

Description was changed from

==========
Fixed some stuff


There were some issues but I think it actually works now


Fixed it for no custom animation. With custom animations? Still an issue

BUG=
==========

to

==========
Disabled custom fullscreen animation since curently it breaks Flash 
content. Made a fix for entering AppKit fullscreen

BUG=567146
==========

[spqchan, 2015-12-15 10:21:04]

Description was changed from

==========
Disabled custom fullscreen animation since curently it breaks Flash 
content. Made a fix for entering AppKit fullscreen

BUG=567146
==========

to

==========
Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=567146
==========

[spqchan, 2015-12-15 10:21:04]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2015-12-15 10:21:48]

PTAL

[Robert Sesek, 2015-12-15 14:57:02]

LGTM

https://codereview.chromium.org/1526533005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/1526533005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:458: BOOL
fullscreen_for_tab = [self isFullscreenForTabContent];
naming: fullscreenForTab (maybe change kioskMode too since you're here)?

[spqchan, 2015-12-15 17:57:03]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2015-12-15 17:57:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1526533005/#ps40001
(title: "Fixed variable names")

[commit-bot: I haz the power, 2015-12-15 17:58:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1526533005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1526533005/40001

[spqchan, 2015-12-15 18:02:53]

Description was changed from

==========
Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=567146
==========

to

==========
Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=566588
==========

[commit-bot: I haz the power, 2015-12-15 18:38:22]

Description was changed from

==========
Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=566588
==========

to

==========
Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=566588
==========

[commit-bot: I haz the power, 2015-12-15 18:38:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-15 18:40:03]

Description was changed from

==========
Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=566588
==========

to

==========
Disabled custom fullscreen animation for entering tab fullscreen since
currently it breaks Flash content. Added a fix so that the flash content is
ensured to take up the entire fullscreen window when it enters fullscreen.

BUG=566588

Committed: https://crrev.com/b97a851fd806a4dfff555f9656a42187498ad06e
Cr-Commit-Position: refs/heads/master@{#365293}
==========

[commit-bot: I haz the power, 2015-12-15 18:40:04]

Patchset 3 (id:??) landed as
https://crrev.com/b97a851fd806a4dfff555f9656a42187498ad06e
Cr-Commit-Position: refs/heads/master@{#365293}