Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1537803002: Revert "Delete the Surfaces service." (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jeffbrown
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Delete the Surfaces service." This reverts commit ce8c91b488cd1da0a66a314a8c36a784d12c2fcd. Reverting unreviewed changes. TBR=jeffbrown@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d16d156f1430a9ff783b404eb6cdb88c0f4710e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3888 lines, -18 lines) Patch
A + examples/bitmap_uploader/BUILD.gn View 1 chunk +13 lines, -18 lines 0 comments Download
A examples/bitmap_uploader/bitmap_uploader.h View 1 chunk +78 lines, -0 lines 0 comments Download
A examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +276 lines, -0 lines 0 comments Download
A examples/surfaces_app/BUILD.gn View 1 chunk +142 lines, -0 lines 0 comments Download
A examples/surfaces_app/child.mojom View 1 chunk +13 lines, -0 lines 0 comments Download
A examples/surfaces_app/child_app.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A examples/surfaces_app/child_gl_app.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A examples/surfaces_app/child_gl_impl.h View 1 chunk +74 lines, -0 lines 0 comments Download
A examples/surfaces_app/child_gl_impl.cc View 1 chunk +207 lines, -0 lines 0 comments Download
A examples/surfaces_app/child_impl.h View 1 chunk +64 lines, -0 lines 0 comments Download
A examples/surfaces_app/child_impl.cc View 1 chunk +83 lines, -0 lines 0 comments Download
A examples/surfaces_app/embedder.h View 1 chunk +40 lines, -0 lines 0 comments Download
A examples/surfaces_app/embedder.cc View 1 chunk +101 lines, -0 lines 0 comments Download
A examples/surfaces_app/surfaces_app.cc View 1 chunk +128 lines, -0 lines 0 comments Download
A examples/surfaces_app/surfaces_util.h View 1 chunk +27 lines, -0 lines 0 comments Download
A examples/surfaces_app/surfaces_util.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A mojo/converters/surfaces/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +147 lines, -0 lines 0 comments Download
A mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +590 lines, -0 lines 0 comments Download
A mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +30 lines, -0 lines 0 comments Download
A mojo/converters/surfaces/tests/surface_unittest.cc View 1 chunk +467 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A services/fake_surfaces/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A services/fake_surfaces/fake_surfaces_service_application.h View 1 chunk +51 lines, -0 lines 0 comments Download
A services/fake_surfaces/fake_surfaces_service_application.cc View 1 chunk +151 lines, -0 lines 0 comments Download
A services/surfaces/BUILD.gn View 1 chunk +48 lines, -0 lines 0 comments Download
A services/surfaces/context_provider_mojo.h View 1 chunk +69 lines, -0 lines 0 comments Download
A services/surfaces/context_provider_mojo.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A services/surfaces/display_factory_impl.h View 1 chunk +44 lines, -0 lines 0 comments Download
A services/surfaces/display_factory_impl.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A services/surfaces/display_impl.h View 1 chunk +80 lines, -0 lines 0 comments Download
A services/surfaces/display_impl.cc View 1 chunk +137 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_impl.h View 1 chunk +67 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_impl.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_output_surface.h View 1 chunk +29 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_output_surface.cc View 1 chunk +42 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_scheduler.h View 1 chunk +58 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_scheduler.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_service_application.h View 1 chunk +55 lines, -0 lines 0 comments Download
A services/surfaces/surfaces_service_application.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M shell/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
viettrungluu
5 years ago (2015-12-17 21:24:10 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d16d156f1430a9ff783b404eb6cdb88c0f4710e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698