chrome/installer/setup/BUILD.gn - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/BUILD.gn

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: addressed final review comments by Alexei Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/BUILD.gn

diff --git a/chrome/installer/setup/BUILD.gn b/chrome/installer/setup/BUILD.gn

index c54637b53152f9c9d1e956d258718cf4ebca3adb..48c103d308ec47408ed84fa7779608687c26bfe6 100644

--- a/chrome/installer/setup/BUILD.gn

+++ b/chrome/installer/setup/BUILD.gn

@@ -41,6 +41,8 @@ if (is_win) {

"installer_crash_reporter_client.h",

"installer_crash_reporting.cc",

"installer_crash_reporting.h",

+ "installer_metrics.cc",

+ "installer_metrics.h",

"setup_constants.cc",

"setup_constants.h",

"setup_util.cc",

« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/setup/installer_metrics.h » ('j') | no next file with comments »