chrome/chrome_installer.gypi - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_installer.gypi

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: addressed final review comments by Alexei Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_installer.gypi

diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi

index a16521fe495d80cd9997a712c311288741863b07..dc4cb5326caf5af150e09b67b43616d5b1cce210 100644

--- a/chrome/chrome_installer.gypi

+++ b/chrome/chrome_installer.gypi

@@ -239,6 +239,8 @@

'installer/setup/installer_crash_reporter_client.h',

'installer/setup/installer_crash_reporting.cc',

'installer/setup/installer_crash_reporting.h',

+ 'installer/setup/installer_metrics.cc',

+ 'installer/setup/installer_metrics.h',

'installer/setup/setup_constants.cc',

'installer/setup/setup_constants.h',

'installer/setup/setup_util.cc',

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/installer/setup/BUILD.gn » ('j') | no next file with comments »