chrome/installer/util/util_constants.h - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/util_constants.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: move AccessResult to .h and add histogram to .xml Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/setup/installer_metrics.cc ('K') | « chrome/installer/util/google_update_constants.h ('k') | chrome/installer/util/util_constants.cc » ('j') | components/metrics/file_metrics_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/util_constants.h

diff --git a/chrome/installer/util/util_constants.h b/chrome/installer/util/util_constants.h

index c7312399377c2cc012851c1ccb5f9fc33691760f..c4271e81db97ddbfff49d921df63ab8b70c9bc05 100644

--- a/chrome/installer/util/util_constants.h

+++ b/chrome/installer/util/util_constants.h

@@ -253,6 +253,10 @@ const int kBsdiffErrorOffset = 600;

extern const char kCourgette[];

extern const char kBsdiff[];

+// Name of allocator (and associated file) for storing histograms to be

Alexei Svitkine (slow) 2016/02/19 18:16:40 Nit: Name of the allocator

bcwhite 2016/02/19 19:50:14 Done.

+// reported by Chrome during its next upload.

+extern const char kSetupHistogramAllocatorName[];

} // namespace installer

#endif // CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_