chrome/installer/util/util_constants.h - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/util_constants.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: move AccessResult to .h and add histogram to .xml Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/installer/setup/installer_metrics.cc ('K') | « chrome/installer/util/google_update_constants.h ('k') | chrome/installer/util/util_constants.cc » ('j') | components/metrics/file_metrics_provider.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Defines all install related constants that need to be used by Chrome as	5 // Defines all install related constants that need to be used by Chrome as

6 // well as Chrome Installer.	6 // well as Chrome Installer.

7	7

8 #ifndef CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_	8 #ifndef CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_

9 #define CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_	9 #define CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_

10	10

(...skipping 235 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
246 // The range of error values for the installer, Courgette, and bsdiff is	246 // The range of error values for the installer, Courgette, and bsdiff is

247 // overlapping. These offset values disambiguate between different sets	247 // overlapping. These offset values disambiguate between different sets

248 // of errors by shifting the values up with the specified offset.	248 // of errors by shifting the values up with the specified offset.

249 const int kCourgetteErrorOffset = 300;	249 const int kCourgetteErrorOffset = 300;

250 const int kBsdiffErrorOffset = 600;	250 const int kBsdiffErrorOffset = 600;

251	251

252 // Arguments to --patch switch	252 // Arguments to --patch switch

253 extern const char kCourgette[];	253 extern const char kCourgette[];

254 extern const char kBsdiff[];	254 extern const char kBsdiff[];

255	255

	256 // Name of allocator (and associated file) for storing histograms to be
	Alexei Svitkine (slow) 2016/02/19 18:16:40 Nit: Name of the allocator Nit: Name of the allocator bcwhite 2016/02/19 19:50:14 Done. Show quoted text On 2016/02/19 18:16:40, Alexei Svitkine wrote: > Nit: Name of the allocator Done.
	257 // reported by Chrome during its next upload.

	258 extern const char kSetupHistogramAllocatorName[];

	259

256 } // namespace installer	260 } // namespace installer

257	261

258 #endif // CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_	262 #endif // CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_

OLD	NEW