chrome/installer/setup/installer_crash_reporting.cc - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Unified Diff: chrome/installer/setup/installer_crash_reporting.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: moved allocator create/destroy to be beside snapshot (simpler code) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/histogram_snapshot_manager.h ('K') | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/installer/setup/setup_main.cc » ('j') | chrome/installer/setup/setup_main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/setup/installer_crash_reporting.cc

diff --git a/chrome/installer/setup/installer_crash_reporting.cc b/chrome/installer/setup/installer_crash_reporting.cc

index fcecd773a729cf49d90e06bd4ba7facb0d938854..3bbedb8e8b62ee68096a43c7598072983ece2b5f 100644

--- a/chrome/installer/setup/installer_crash_reporting.cc

+++ b/chrome/installer/setup/installer_crash_reporting.cc

@@ -121,7 +121,11 @@ void ConfigureCrashReporting(const InstallerState& installer_state) {

size_t RegisterCrashKeys() {

const base::debug::CrashKey kFixedKeys[] = {

+#if defined(OS_MACOSX) || defined(OS_WIN)

grt (UTC plus 2) 2016/02/04 15:36:42 this file is exclusively OS_WIN, so there's no nee

bcwhite 2016/02/04 21:51:13 This whole file will not be in the final submit.

grt (UTC plus 2) 2016/02/08 18:09:18 Gotcha. That other CL landed, so you should be abl

bcwhite 2016/02/09 21:08:45 Done.

+ { crash_keys::kMetricsClientId, crash_keys::kSmallSize },

+#else

{ crash_keys::kClientId, crash_keys::kSmallSize },

+#endif

{ kCurrentVersion, crash_keys::kSmallSize },

{ kDistributionType, crash_keys::kSmallSize },

{ kIsMultiInstall, crash_keys::kSmallSize },