Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: moved allocator create/destroy to be beside snapshot (simpler code) Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index d980cd98e78afe021b813522d49ddbd23d5cbaee..91cf8892bdf142cf6dbaa8b6fc60024ffaf90d43 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -32,8 +32,10 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/crash_keys.h"
#include "chrome/common/features.h"
+#include "chrome/installer/util/util_constants.h"
#include "components/metrics/call_stack_profile_metrics_provider.h"
#include "components/metrics/drive_metrics_provider.h"
+#include "components/metrics/file_metrics_provider.h"
#include "components/metrics/gpu/gpu_metrics_provider.h"
#include "components/metrics/metrics_pref_names.h"
#include "components/metrics/metrics_service.h"
@@ -177,6 +179,9 @@ void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) {
metrics::MetricsService::RegisterPrefs(registry);
metrics::StabilityMetricsHelper::RegisterPrefs(registry);
+ metrics::FileMetricsProvider::RegisterPrefs(
+ registry, installer::kSetupHistogramAllocatorName);
+
#if BUILDFLAG(ANDROID_JAVA_UI)
AndroidMetricsProvider::RegisterPrefs(registry);
#endif // BUILDFLAG(ANDROID_JAVA_UI)
@@ -335,6 +340,19 @@ void ChromeMetricsServiceClient::Initialize() {
scoped_ptr<metrics::MetricsProvider>(
new metrics::ScreenInfoMetricsProvider));
+#if defined(OS_WIN)
+ scoped_ptr<metrics::FileMetricsProvider> file_metrics(
+ new metrics::FileMetricsProvider(metrics_service_.get(),
+ g_browser_process->local_state()));
+ file_metrics->RegisterFile(
+ base::CommandLine::ForCurrentProcess()->GetProgram().DirName()
+ .AppendASCII(installer::kSetupHistogramAllocatorName)
+ .AddExtension(L".pma"),
+ metrics::FileMetricsProvider::FILE_HISTOGRAMS_ATOMIC,
+ installer::kSetupHistogramAllocatorName);
+ metrics_service_->RegisterMetricsProvider(std::move(file_metrics));
+#endif
+
drive_metrics_provider_ = new metrics::DriveMetricsProvider(
content::BrowserThread::GetMessageLoopProxyForThread(
content::BrowserThread::FILE),
@@ -523,7 +541,7 @@ void ChromeMetricsServiceClient::OnMemoryDetailCollectionDone() {
}
#endif // !ENABLE_PRINT_PREVIEW
- // Set up the callback to task to call after we receive histograms from all
+ // Set up the callback task to call after we receive histograms from all
// child processes. |timeout| specifies how long to wait before absolutely
// calling us back on the task.
content::FetchHistogramsAsynchronously(base::MessageLoop::current(), callback,

Powered by Google App Engine
This is Rietveld 408576698