chrome/installer/setup/setup_constants.h - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_constants.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_setup_metrics_provider.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | chrome/installer/setup/setup_main.cc » ('j') | chrome/installer/util/google_update_constants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/setup/setup_constants.h

diff --git a/chrome/installer/setup/setup_constants.h b/chrome/installer/setup/setup_constants.h

index 4b958201cd340da8bc017cd91eccef97f2564ce3..f8c1bf60b33e149e51c2945a82958f37ae33052d 100644

--- a/chrome/installer/setup/setup_constants.h

+++ b/chrome/installer/setup/setup_constants.h

@@ -7,6 +7,8 @@

#ifndef CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__

#define CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__

+#include <stdint.h>

grt (UTC plus 2) 2015/12/18 21:02:50 both wchar_t and char (the two types used in this

bcwhite 2015/12/21 15:47:25 Odd. Not sure why that showed up. Done.

namespace installer {

extern const wchar_t kChromeArchive[];