chrome/installer/setup/setup_constants.h - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/setup/setup_constants.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/chrome_setup_metrics_provider.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | chrome/installer/setup/setup_main.cc » ('j') | chrome/installer/util/google_update_constants.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the command-line switches used by Chrome installer.	5 // Defines all the command-line switches used by Chrome installer.

6	6

7 #ifndef CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__	7 #ifndef CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__

8 #define CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__	8 #define CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__

9	9

	10 #include <stdint.h>
	grt (UTC plus 2) 2015/12/18 21:02:50 both wchar_t and char (the two types used in this both wchar_t and char (the two types used in this file) are keywords in C++-03, so i don't think this is needed. bcwhite 2015/12/21 15:47:25 Odd. Not sure why that showed up. Done. Show quoted text On 2015/12/18 21:02:50, grt wrote: > both wchar_t and char (the two types used in this file) are keywords in C++-03, > so i don't think this is needed. Odd. Not sure why that showed up. Done.
	11

10 namespace installer {	12 namespace installer {

11	13

12 extern const wchar_t kChromeArchive[];	14 extern const wchar_t kChromeArchive[];

13 extern const wchar_t kChromeCompressedArchive[];	15 extern const wchar_t kChromeCompressedArchive[];

14 extern const wchar_t kVisualElements[];	16 extern const wchar_t kVisualElements[];

15 extern const wchar_t kVisualElementsManifest[];	17 extern const wchar_t kVisualElementsManifest[];

16 extern const wchar_t kWowHelperExe[];	18 extern const wchar_t kWowHelperExe[];

17	19

18 extern const wchar_t kInstallSourceDir[];	20 extern const wchar_t kInstallSourceDir[];

19 extern const wchar_t kInstallSourceChromeDir[];	21 extern const wchar_t kInstallSourceChromeDir[];

20	22

21 extern const wchar_t kMediaPlayerRegPath[];	23 extern const wchar_t kMediaPlayerRegPath[];

22	24

23 namespace switches {	25 namespace switches {

24	26

25 extern const char kDelay[];	27 extern const char kDelay[];

26 extern const char kSetDisplayVersionProduct[];	28 extern const char kSetDisplayVersionProduct[];

27 extern const char kSetDisplayVersionValue[];	29 extern const char kSetDisplayVersionValue[];

28	30

29 } // namespace switches	31 } // namespace switches

30	32

31 } // namespace installer	33 } // namespace installer

32	34

33 #endif // CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__	35 #endif // CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__

OLD	NEW