Fix ContentViewCore height for fullscreen panel

Fix ContentViewCore height for fullscreen panel

Add fullscreen checks to the ContentViewClient responsible
for sizing the ContentViewCore.

BUG=568616, 560130
Committed: https://crrev.com/cbdf827e607ba0aeb69ea5b712f614adb6f5fc33
Cr-Commit-Position: refs/heads/master@{#365940}

[mdjones, 2015-12-17 18:55:41]

Description was changed from

==========
Fix ContentViewCore height for fullscreen panel

Height calculation in the base panel class is incorrect for
fullscreen panels when MeasureSpec is "EXACTLY".

BUG=568616, 560130
==========

to

==========
Fix ContentViewCore height for fullscreen panel

Height calculation in the base panel class is incorrect for
fullscreen panels when MeasureSpec is "EXACTLY". This change
modifies a previously unused code path to correctly set this
value.

BUG=568616, 560130
==========

[mdjones, 2015-12-17 18:56:00]

mdjones@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[mdjones, 2015-12-17 18:56:00]

PTAL

[pedro (no code reviews), 2015-12-17 22:56:46]

https://codereview.chromium.org/1537733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/1537733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:321:
return MeasureSpec.makeMeasureSpec(
do the same here

https://codereview.chromium.org/1537733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:330:
}
Nit: put an else block

[mdjones, 2015-12-17 23:00:53]

Description was changed from

==========
Fix ContentViewCore height for fullscreen panel

Height calculation in the base panel class is incorrect for
fullscreen panels when MeasureSpec is "EXACTLY". This change
modifies a previously unused code path to correctly set this
value.

BUG=568616, 560130
==========

to

==========
Fix ContentViewCore height for fullscreen panel

Add fullscreen checks to the ContentViewClient responsible
for sizing the ContentViewCore.

BUG=568616, 560130
==========

[mdjones, 2015-12-17 23:01:15]

https://codereview.chromium.org/1537733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/1537733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:321:
return MeasureSpec.makeMeasureSpec(
On 2015/12/17 22:56:46, pedrosimonetti wrote:
> do the same here

Done.

https://codereview.chromium.org/1537733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:330:
}
On 2015/12/17 22:56:46, pedrosimonetti wrote:
> Nit: put an else block

Done.

[pedro (no code reviews), 2015-12-17 23:01:56]

lgtm

[mdjones, 2015-12-17 23:02:31]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2015-12-17 23:04:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537733002/40001

[commit-bot: I haz the power, 2015-12-17 23:47:16]

Description was changed from

==========
Fix ContentViewCore height for fullscreen panel

Add fullscreen checks to the ContentViewClient responsible
for sizing the ContentViewCore.

BUG=568616, 560130
==========

to

==========
Fix ContentViewCore height for fullscreen panel

Add fullscreen checks to the ContentViewClient responsible
for sizing the ContentViewCore.

BUG=568616, 560130
==========

[commit-bot: I haz the power, 2015-12-17 23:47:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-17 23:48:30]

Description was changed from

==========
Fix ContentViewCore height for fullscreen panel

Add fullscreen checks to the ContentViewClient responsible
for sizing the ContentViewCore.

BUG=568616, 560130
==========

to

==========
Fix ContentViewCore height for fullscreen panel

Add fullscreen checks to the ContentViewClient responsible
for sizing the ContentViewCore.

BUG=568616, 560130

Committed: https://crrev.com/cbdf827e607ba0aeb69ea5b712f614adb6f5fc33
Cr-Commit-Position: refs/heads/master@{#365940}
==========

[commit-bot: I haz the power, 2015-12-17 23:48:31]

Patchset 3 (id:??) landed as
https://crrev.com/cbdf827e607ba0aeb69ea5b712f614adb6f5fc33
Cr-Commit-Position: refs/heads/master@{#365940}