Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 1537733002: Fix ContentViewCore height for fullscreen panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use first approach Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
index 6913308b12a6b02dabefa4f88ec2eeb1feea5106..c519959ad2457e0b68058243cf77f7f26be48a88 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
@@ -318,16 +318,24 @@ public class OverlayPanel extends ContextualSearchPanelAnimation
content.setContentViewClient(new ContentViewClient() {
@Override
public int getDesiredWidthMeasureSpec() {
- return MeasureSpec.makeMeasureSpec(
- getSearchContentViewWidthPx(),
- MeasureSpec.EXACTLY);
+ if (isFullscreenSizePanel()) {
+ return super.getDesiredWidthMeasureSpec();
+ } else {
+ return MeasureSpec.makeMeasureSpec(
+ getSearchContentViewWidthPx(),
+ MeasureSpec.EXACTLY);
+ }
}
@Override
public int getDesiredHeightMeasureSpec() {
- return MeasureSpec.makeMeasureSpec(
- getSearchContentViewHeightPx(),
- MeasureSpec.EXACTLY);
+ if (isFullscreenSizePanel()) {
+ return super.getDesiredHeightMeasureSpec();
+ } else {
+ return MeasureSpec.makeMeasureSpec(
+ getSearchContentViewHeightPx(),
+ MeasureSpec.EXACTLY);
+ }
}
});
return content;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698