Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: unittest/AssemblerX8664/ControlFlow.cpp

Issue 1537703002: Subzero. x8664. Resurrects the Target. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: unittest/AssemblerX8664/ControlFlow.cpp
diff --git a/unittest/AssemblerX8664/ControlFlow.cpp b/unittest/AssemblerX8664/ControlFlow.cpp
index d22cca541c6a75f8e5f82a5eba7f2083679eb6bf..47272fa5f4e764633f4495b3921896d077ecfa42 100644
--- a/unittest/AssemblerX8664/ControlFlow.cpp
+++ b/unittest/AssemblerX8664/ControlFlow.cpp
@@ -160,6 +160,7 @@ TEST_F(AssemblerX8664Test, CallAddr) {
do { \
const uint32_t T0 = allocateQword(); \
const uint64_t V0 = 0xA0C0FFEEBEEFFEEFull; \
+ const uint32_t T1 = allocateDword(); \
__ call(Immediate(16)); \
int CallTargetAddr = codeBytesSize() + 12; \
__ mov(IceType_i8, Encoded_GPR_##Dst##l(), Immediate(0xf4)); \
@@ -168,9 +169,9 @@ TEST_F(AssemblerX8664Test, CallAddr) {
__ hlt(); \
} \
__ mov(IceType_i64, Encoded_GPR_##Dst##q(), dwordAddress(T0)); \
- __ mov(IceType_i64, Encoded_GPR_##Src##q(), Encoded_GPR_rsp()); \
- __ call(Address(Encoded_GPR_##Src##q(), 0, AssemblerFixup::NoFixup)); \
__ popl(Encoded_GPR_##Src##q()); \
+ __ mov(IceType_i32, dwordAddress(T1), Encoded_GPR_##Src##d()); \
+ __ call(dwordAddress(T1)); \
\
AssembledTest test = assemble(); \
test.setQwordTo(T0, V0); \

Powered by Google App Engine
This is Rietveld 408576698