Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1537683002: Partial revert of rest parameter desugaring. (Closed)

Created:
5 years ago by mvstanton
Modified:
4 years, 11 months ago
Reviewers:
*Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Partial revert of rest parameter desugaring. We'll be able to optimize rest parameters in TurboFan similarly to the arguments array. This CL restores the previous behavior, and a follow-on will enable TurboFan optimization. (TBR for rossberg since we discussed the revert beforehand. The only changes are a few lines related to tests and rebasing.) TBR=rossberg@chromium.org BUG= Committed: https://crrev.com/d3f074b23195a2426d14298dca30c4cf9183f203 Cr-Commit-Position: refs/heads/master@{#33024}

Patch Set 1 #

Patch Set 2 : bugfix. #

Patch Set 3 : REBASE. #

Patch Set 4 : Ports. #

Patch Set 5 : REBASE. #

Patch Set 6 : Fix test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -118 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M src/ast/ast-literal-reindexer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopes.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/ast/scopes.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M src/parsing/parser.h View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 4 6 chunks +5 lines, -82 lines 0 comments Download
M src/parsing/parser-base.h View 1 2 3 4 chunks +3 lines, -12 lines 0 comments Download
M src/parsing/preparser.h View 4 chunks +1 line, -19 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsobjects.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
mvstanton
Hi guys, Here is step 1 of the restructuring of rest args. It reverts the ...
5 years ago (2015-12-22 17:40:49 UTC) #4
caitp (gmail)
On 2015/12/22 17:40:49, mvstanton wrote: > Hi guys, > Here is step 1 of the ...
5 years ago (2015-12-22 17:57:15 UTC) #5
caitp (gmail)
On 2015/12/22 17:57:15, caitp wrote: > On 2015/12/22 17:40:49, mvstanton wrote: > > Hi guys, ...
5 years ago (2015-12-22 18:13:30 UTC) #6
Benedikt Meurer
LGTM on the approach as discussed offline yesterday modulo test failures.
5 years ago (2015-12-23 04:56:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537683002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537683002/100001
5 years ago (2015-12-23 12:01:30 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-23 12:07:09 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-23 12:07:36 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d3f074b23195a2426d14298dca30c4cf9183f203
Cr-Commit-Position: refs/heads/master@{#33024}

Powered by Google App Engine
This is Rietveld 408576698