Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: test/cctest/compiler/test-run-jsobjects.cc

Issue 1537683002: Partial revert of rest parameter desugaring. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix test failures. Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "test/cctest/compiler/function-tester.h" 5 #include "test/cctest/compiler/function-tester.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 namespace internal { 8 namespace internal {
9 namespace compiler { 9 namespace compiler {
10 10
(...skipping 17 matching lines...) Expand all
28 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments); 28 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
29 CHECK(arguments->IsJSObject() && !arguments->IsJSArray()); 29 CHECK(arguments->IsJSObject() && !arguments->IsJSArray());
30 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements()); 30 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements());
31 Handle<String> l = T.isolate->factory()->length_string(); 31 Handle<String> l = T.isolate->factory()->length_string();
32 Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked(); 32 Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked();
33 CHECK_EQ(4, length->Number()); 33 CHECK_EQ(4, length->Number());
34 } 34 }
35 35
36 36
37 TEST(ArgumentsRest) { 37 TEST(ArgumentsRest) {
38 // TODO(mvstanton): restore this test when Turbofan again supports rest args.
39 // (soon).
40 return;
38 FunctionTester T("(function(a, ...args) { return args; })"); 41 FunctionTester T("(function(a, ...args) { return args; })");
39 42
40 Handle<Object> arguments; 43 Handle<Object> arguments;
41 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments); 44 T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
42 CHECK(arguments->IsJSObject() && arguments->IsJSArray()); 45 CHECK(arguments->IsJSObject() && arguments->IsJSArray());
43 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements()); 46 CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements());
44 Handle<String> l = T.isolate->factory()->length_string(); 47 Handle<String> l = T.isolate->factory()->length_string();
45 Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked(); 48 Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked();
46 CHECK_EQ(3, length->Number()); 49 CHECK_EQ(3, length->Number());
47 } 50 }
48 51
49 } // namespace compiler 52 } // namespace compiler
50 } // namespace internal 53 } // namespace internal
51 } // namespace v8 54 } // namespace v8
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698