Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1537553002: Replace typedef with using for Callback/Bind related files (Closed)

Created:
5 years ago by tzik
Modified:
5 years ago
Reviewers:
danakj
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace typedef with using for Callback/Bind related files This CL contains: * Replace typedef with using. * Remove |void| from no-parameter function declarations. * Fix an error in a comment. BUG= Committed: https://crrev.com/3bc7779ba002f50675a18e2eae277d4617788e21 Cr-Commit-Position: refs/heads/master@{#366278}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : MSVC fix #

Patch Set 4 : +comment #

Patch Set 5 : fix #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -142 lines) Patch
M base/bind.h View 1 2 3 4 5 2 chunks +7 lines, -8 lines 0 comments Download
M base/bind_helpers.h View 1 2 3 4 5 11 chunks +19 lines, -17 lines 0 comments Download
M base/bind_internal.h View 1 2 3 4 5 5 chunks +19 lines, -13 lines 0 comments Download
M base/bind_internal_win.h View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M base/bind_unittest.cc View 1 2 3 4 5 22 chunks +46 lines, -46 lines 0 comments Download
M base/bind_unittest.nc View 10 chunks +12 lines, -12 lines 0 comments Download
M base/callback.h View 1 2 3 7 chunks +12 lines, -10 lines 0 comments Download
M base/callback_forward.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/callback_internal.h View 5 chunks +11 lines, -11 lines 0 comments Download
M base/callback_unittest.cc View 1 2 3 4 6 chunks +17 lines, -16 lines 0 comments Download
M base/callback_unittest.nc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
tzik
PTAL.
5 years ago (2015-12-17 01:45:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537553002/1
5 years ago (2015-12-17 02:36:51 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/416) cast_shell_linux on ...
5 years ago (2015-12-17 03:09:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537553002/20001
5 years ago (2015-12-17 04:16:36 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/151130)
5 years ago (2015-12-17 05:06:57 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537553002/60001
5 years ago (2015-12-17 07:11:38 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/146312)
5 years ago (2015-12-17 07:56:57 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537553002/80001
5 years ago (2015-12-17 08:29:23 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 09:53:48 UTC) #18
danakj
LGTM thanks!
5 years ago (2015-12-18 19:51:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537553002/80001
5 years ago (2015-12-18 19:53:04 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/109956) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-18 19:56:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537553002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537553002/100001
5 years ago (2015-12-19 07:36:47 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-19 09:18:55 UTC) #27
commit-bot: I haz the power
5 years ago (2015-12-19 09:20:13 UTC) #29
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/3bc7779ba002f50675a18e2eae277d4617788e21
Cr-Commit-Position: refs/heads/master@{#366278}

Powered by Google App Engine
This is Rietveld 408576698