Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/isolate.cc

Issue 1537543002: Fix for issue 25236 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code-review-comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/dart.cc ('K') | « runtime/vm/gc_sweeper.cc ('k') | runtime/vm/os_thread.h » ('j') | runtime/vm/os_thread.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index fe5289180a6a853a853c82ff35c8e883cfc0c9fe..5267492e99f86a235702569d2c47a73ca398df63 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -876,7 +876,8 @@ Isolate* Isolate::Init(const char* name_prefix,
// TODO(5411455): For now just set the recently created isolate as
// the current isolate.
- Thread::EnterIsolate(result);
+ bool retval = Thread::EnterIsolate(result);
+ ASSERT(retval);
zra 2015/12/17 19:01:43 I think this should be a FATAL(). Otherwise if Dar
siva 2015/12/17 23:21:14 Done.
// Setup the isolate message handler.
MessageHandler* handler = new IsolateMessageHandler(result);
« runtime/vm/dart.cc ('K') | « runtime/vm/gc_sweeper.cc ('k') | runtime/vm/os_thread.h » ('j') | runtime/vm/os_thread.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698