Fix for issue 25236

runtime/vm/dart.cc

Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index 75689247de36c62c526e186d9aea4ec9f742e5ce..024f6530f8bf8dd1d6cfc6635ac8f134c82e403a 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -222,13 +222,18 @@ const char* Dart::Cleanup() {
     return "VM already terminated.";
   }
 
+  // Disable creation of any new OSThread structures which means no more new
+  // threads can do an EnterIsolate.
+  OSThread::DisableOSThreadCreation();

[zra, 2015/12/17 19:01:43]

Should we defend against concurrent/multiple calls to Dart_Cleanup()? We could
catch that here if OSThread creation is already disabled.

[siva, 2015/12/17 23:21:14]

Will probably do that in a different CL, I don't think checking for OSThread
creation is foolproof we can have a racing Dart_Cleanup call before
OSThread::InitOnce is called and we should be able to recognize that as a
preemptive call (not sure what to do here maybe a different error) Vs multiple
calls to Dart_Cleanup.

+
   // Shut down profiling.
   Profiler::Shutdown();
 
   {
     // Set the VM isolate as current isolate when shutting down
     // Metrics so that we can use a StackZone.
-    Thread::EnterIsolate(vm_isolate_);
+    bool result = Thread::EnterIsolate(vm_isolate_);
+    ASSERT(result);
     Metric::Cleanup();
     Thread::ExitIsolate();
   }
@@ -252,7 +257,8 @@ const char* Dart::Cleanup() {
     thread_pool_ = NULL;
 
     // Set the VM isolate as current isolate.
-    Thread::EnterIsolate(vm_isolate_);
+    bool result = Thread::EnterIsolate(vm_isolate_);
+    ASSERT(result);
 
     ShutdownIsolate();
     vm_isolate_ = NULL;
@@ -407,7 +413,8 @@ void Dart::RunShutdownCallback() {
 void Dart::ShutdownIsolate(Isolate* isolate) {
   ASSERT(Isolate::Current() == NULL);
   // We need to enter the isolate in order to shut it down.
-  Thread::EnterIsolate(isolate);
+  bool result = Thread::EnterIsolate(isolate);
+  ASSERT(result);
   ShutdownIsolate();
   // Since the isolate is shutdown and deleted, there is no need to
   // exit the isolate here.