Add correct equality testing for ComputedStyle's StyleVariableData

Add correct equality testing for ComputedStyle's StyleVariableData
objects.

This fixes the linked bug (large subtree style recalcs always when
using variables) and prevents a crash in release-with-asserts
builds that attempt to equality check the base style with a freshly
computed style during animations.

BUG=570176
Committed: https://crrev.com/b6cb0b15a9507e782b2b0fb1a67b35e7d81c45f9
Cr-Commit-Position: refs/heads/master@{#365814}

[shans, 2015-12-17 03:56:42]

shans@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2015-12-17 04:22:56]

Might be worthwhile to add EXPECT_EQ(expected, actual) to the top of
compareTokens in CSSTokenizerTest for some coverage. If you can make a layout
test that would hit the baseComputedStyle assert, that'd be good too.

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParserToken.h (right):

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserToken.h:96: if
(m_hashTokenType != other.m_hashTokenType)
This is only really for HashTokens

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserToken.h:105: case
DimensionToken:
These also have a dimension (i.e. string) attached.

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/StyleVariableData.cpp (right):

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/StyleVariableData.cpp:18: for (const auto
iter : m_data) {
const auto& probably

[shans, 2015-12-17 05:14:14]

Layout test and EXPECT_EQ added.

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParserToken.h (right):

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserToken.h:96: if
(m_hashTokenType != other.m_hashTokenType)
On 2015/12/17 at 04:22:56, Timothy Loh wrote:
> This is only really for HashTokens

my bad - I ordered the cases incorrectly.

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserToken.h:105: case
DimensionToken:
On 2015/12/17 at 04:22:56, Timothy Loh wrote:
> These also have a dimension (i.e. string) attached.

that isn't just the numericValueType? Fixed, at any rate.

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/StyleVariableData.cpp (right):

https://codereview.chromium.org/1537523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/StyleVariableData.cpp:18: for (const auto
iter : m_data) {
On 2015/12/17 at 04:22:56, Timothy Loh wrote:
> const auto& probably

Done.

[shans, 2015-12-17 09:34:29]

shans@chromium.org changed reviewers:
+ dstockwell@chromium.org

[dstockwell, 2015-12-17 09:45:16]

lgtm

https://codereview.chromium.org/1537523003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParserToken.h (right):

https://codereview.chromium.org/1537523003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserToken.h:100: return
m_valueDataCharRaw == other.m_valueDataCharRaw && m_valueLength ==
other.m_valueLength && m_valueIs8Bit == other.m_valueIs8Bit;
We should probably compare the contents too, I assume we can produce the same
computed value with different tokens. TODO?

[shans, 2015-12-17 10:07:40]

On 2015/12/17 at 09:45:16, dstockwell wrote:
> lgtm
> 
>
https://codereview.chromium.org/1537523003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/parser/CSSParserToken.h (right):
> 
>
https://codereview.chromium.org/1537523003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/parser/CSSParserToken.h:100: return
m_valueDataCharRaw == other.m_valueDataCharRaw && m_valueLength ==
other.m_valueLength && m_valueIs8Bit == other.m_valueIs8Bit;
> We should probably compare the contents too, I assume we can produce the same
computed value with different tokens. TODO?

https://code.google.com/p/chromium/issues/detail?id=570620

[shans, 2015-12-17 10:07:46]

The CQ bit was checked by shans@chromium.org

[commit-bot: I haz the power, 2015-12-17 10:08:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537523003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537523003/40001

[commit-bot: I haz the power, 2015-12-17 11:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 11:06:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shans, 2015-12-17 11:13:30]

The CQ bit was checked by shans@chromium.org

[shans, 2015-12-17 11:13:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1537523003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 11:13:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537523003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537523003/60001

[commit-bot: I haz the power, 2015-12-17 12:45:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-17 12:46:35]

Description was changed from

==========
Add correct equality testing for ComputedStyle's StyleVariableData
objects.

This fixes the linked bug (large subtree style recalcs always when
using variables) and prevents a crash in release-with-asserts
builds that attempt to equality check the base style with a freshly
computed style during animations.

BUG=570176
==========

to

==========
Add correct equality testing for ComputedStyle's StyleVariableData
objects.

This fixes the linked bug (large subtree style recalcs always when
using variables) and prevents a crash in release-with-asserts
builds that attempt to equality check the base style with a freshly
computed style during animations.

BUG=570176

Committed: https://crrev.com/b6cb0b15a9507e782b2b0fb1a67b35e7d81c45f9
Cr-Commit-Position: refs/heads/master@{#365814}
==========

[commit-bot: I haz the power, 2015-12-17 12:46:36]

Patchset 4 (id:??) landed as
https://crrev.com/b6cb0b15a9507e782b2b0fb1a67b35e7d81c45f9
Cr-Commit-Position: refs/heads/master@{#365814}