third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp - Issue 1537523003: Add correct equality testing for ComputedStyle's StyleVariableData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

Issue 1537523003: Add correct equality testing for ComputedStyle's StyleVariableData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserToken.h ('k') | third_party/WebKit/Source/core/style/StyleVariableData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp b/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

index f1ef75008357953ba99374920a7e476b8afd7936..9fc1b280f6d3670bcee4fa31cd2421c57a838ee6 100644

--- a/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

+++ b/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

@@ -223,7 +223,7 @@ bool StyleRareInheritedData::operator==(const StyleRareInheritedData& o) const

&& m_rubyPosition == o.m_rubyPosition

&& dataEquivalent(listStyleImage.get(), o.listStyleImage.get())

&& dataEquivalent(appliedTextDecorations, o.appliedTextDecorations)

- && variables == o.variables;

+ && dataEquivalent(variables, o.variables);

}

bool StyleRareInheritedData::shadowDataEquivalent(const StyleRareInheritedData& o) const