Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: ui/touch_selection/touch_selection_controller.h

Issue 1537493006: Allow scrolling a page with selection after long-press on whitespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/touch_selection/touch_selection_controller.h
diff --git a/ui/touch_selection/touch_selection_controller.h b/ui/touch_selection/touch_selection_controller.h
index ae0161b7734e3658f822d9a8ebc534206dcc1db6..164f2a9df8c357e15cfa37f44663dc44482ae82e 100644
--- a/ui/touch_selection/touch_selection_controller.h
+++ b/ui/touch_selection/touch_selection_controller.h
@@ -101,6 +101,10 @@ class UI_TOUCH_SELECTION_EXPORT TouchSelectionController
bool WillHandleLongPressEvent(base::TimeTicks event_time,
const gfx::PointF& location);
+ // To be called before forwarding a gesture scroll begin event to prevent
+ // long-press drag.
+ void OnScrollBeginEvent();
+
// Allow showing the selection handles from the most recent selection bounds
// update (if valid), or a future valid bounds update.
void AllowShowingFromCurrentSelection();
« no previous file with comments | « ui/touch_selection/longpress_drag_selector_unittest.cc ('k') | ui/touch_selection/touch_selection_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698